Default delete & dataset creation fix (#341)

Co-authored-by: Martin Kozlovsky <[email protected]>

Author: JSabadin

luxonis_ml/data/__main__.py

@@ -333,7 +333,7 @@ def inspect(
     bucket_storage: BucketStorage = bucket_option,
 ):
     """Inspects images and annotations in a dataset."""
-
+    check_exists(name, bucket_storage)
     if deterministic:
         np.random.seed(42)
         random.seed(42)

luxonis_ml/data/datasets/luxonis_dataset.py

@@ -874,6 +874,11 @@ def delete_dataset(
         @param delete_local: Whether to delete the dataset from local
             storage.
         """
+        if not (delete_remote or delete_local):
+            raise ValueError(
+                "Must set delete_remote=True and/or delete_local=True when calling delete_dataset()"
+            )
+
         if not self.is_remote and delete_local:
             logger.info(
                 f"Deleting local dataset '{self.dataset_name}' from local storage"
@@ -1502,7 +1507,7 @@ def _dump_annotations(
                             Path(
                                 data_path.name,
                                 str(image_indices[file]) + file.suffix,
-                            )
+                            ).as_posix()
                         ),
                         "task_name": task_name,
                     }
@@ -1515,7 +1520,7 @@ def _dump_annotations(
                     Path(
                         data_path.name,
                         str(image_indices[file]) + file.suffix,
-                    )
+                    ).as_posix()
                 ),
                 "task_name": task_name,
                 "annotation": {

tests/test_data/test_dataset.py

@@ -151,6 +151,9 @@ def generator() -> DatasetIterator:
     with pytest.raises(ValueError, match="Must provide either"):
         dataset.set_skeletons()
 
+    with pytest.raises(ValueError, match="Must set delete_remote"):
+        dataset.delete_dataset()
+
 
 @pytest.mark.dependency(name="test_dataset[BucketStorage.LOCAL]")
 def test_loader_iterator(storage_url: str, tempdir: Path):

tests/test_data/test_parsers.py

@@ -102,7 +102,7 @@ def test_dir_parser(
     _, ann = next(iter(loader))
     task_types = {get_task_type(task) for task in ann}
     assert task_types == expected_task_types
-    dataset.delete_dataset()
+    dataset.delete_dataset(delete_local=True)
 
 
 @pytest.mark.parametrize(
@@ -215,4 +215,4 @@ def test_dir_parser_explicit_type(
     _, ann = next(iter(loader))
     task_types = {get_task_type(task) for task in ann}
     assert task_types == expected_task_types
-    dataset.delete_dataset()
+    dataset.delete_dataset(delete_local=True)