Skip to content

Commit f2cf992

Browse files
authored
Error on empty make_splits (#326)
1 parent f9b018a commit f2cf992

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

luxonis_ml/data/datasets/luxonis_dataset.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1118,6 +1118,8 @@ def make_splits(
11181118
if isinstance(splits, tuple):
11191119
ratios = splits
11201120
elif isinstance(splits, dict):
1121+
if not splits:
1122+
raise ValueError("Splits cannot be empty")
11211123
value = next(iter(splits.values()))
11221124
if isinstance(value, float):
11231125
ratios = splits # type: ignore

tests/test_data/test_dataset.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,9 @@ def generator(step: int = 15) -> DatasetIterator:
237237
with pytest.raises(ValueError, match="No new files"):
238238
dataset.make_splits()
239239

240+
with pytest.raises(ValueError, match="Splits cannot be empty"):
241+
dataset.make_splits({})
242+
240243
with pytest.raises(ValueError, match="Ratios must sum to 1.0"):
241244
dataset.make_splits((0.7, 0.1, 1))
242245

0 commit comments

Comments
 (0)