Skip to content

Error in unace file listing parser #187

@tartpvule

Description

@tartpvule
Expected Behavior

Scrubbed output below in the "Context" section. Sorry, private data.
Listing of ACE files should only show "real" files, without including a "file" named "bytes (compressed x.xxxX)".

Current Behavior

A "file" named "bytes (compressed x.xxxX)" is shown in the file listing UI.

Possible Solution

Fix process_line function in fr-command-ace.c to stop when it encounters a line that starts with "listed: "

Steps to Reproduce (for bugs)
  1. Get a .ace compressed archive somehow, or download WinAce Trial (like from softpedia.com) and make an archive. Calling this "test.ace".
  2. Run unace v test.ace from a terminal and observe the output
  3. Open "test.ace" from lxqt-archiver and observe the file listing
  4. Observe that bytes (compressed x.xxxx) is shown as a filename
Context

Tried opening an ancient ACE archive from early 2000s with lxqt-archiver in 2020.
Output with filenames and numbers scrubbed:

UNACE v2.5     Copyright by ACE Compression Software       Jan 25 2020 21:01:27

processing archive /tmp/scrubbed.ace
created on xx.xx.xxxx with ver 2.0 by
*UNREGISTERED VERSION*
Contents of archive scrubbed.ace

  Date    Time     Packed      Size  Ratio  File

xx.xx.xx xx:xx     xxxxxxx   xxxxxxx   xx%  filename1
xx.xx.xx xx:xx     xxxxxxx   xxxxxxx   xx%  filename2
xx.xx.xx xx:xx     xxxxxxx   xxxxxxx   xx%  filename3

listed: 3 files, totaling x.xxxX bytes (compressed x.xxxX)

Using "unace 2.5-11" package from ArchLinux, which is "non-free" version

System Information
  • Distribution & Version: ArchLinux
  • Kernel: Irrelevant
  • Qt Version: Irrelevant
  • libqtxdg Version: Irrelevant
  • lxqt-build-tools Version: Irrelevant
  • Package version: lxqt-archiver 0.2.0

Best Regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions