The wallpaper goes off screen in labwc Wayland sessions #1974
Comments
|
Do you mean that, with a scaling factor of 1.5 set by kanshi, it happens only when you change the wallpaper?
As if the scaling factor was 2, instead of 1.5? |
yes
also yes |
|
Thanks. I'll check whether the problem is in the code — although if it was, it should have happened in the other 2 cases too. |
|
If you restart the desktop module in "Session Settings" will the wallpaper be correct? EDIT: answered, didn't read well. I noticed this before too. |
It's very strange because the same functions are called in all cases, and if they work fine at the startup, they should work fine in the middle of a session. However, I should find time and re-read the code... |
|
The same happens changing scale factor on the fly, the desktop has to be restarted afterwards to show the wallpaper correctly. |
The problem can't be in pcmanfm-qt; I checked its code. |
|
I think a workaround is possible. Moving the report to pcmanfm-qt's tracker.... |
Due to a bug in Qt, `QScreen::devicePixelRatio()` may give a rounded (ceiling?) integer on Wayland, while `QWindow::devicePixelRatio()` always gives the correct ratio. Closes #1974 NOTE: This also works with an on-the-fly change of the scaling with kanshi.
|
The workaround is here: #1975. It passed my tests under Labwc. |
Expected Behavior
Current Behavior
Setting the wallpaper causes the wallpaper to be set as if the screen is larger than it really is, eg: stretch/zoom to fill will cause the wallpaper to go off-screen to the right and bottom of the screen, or centering a small image would have it offset to the right/down of where it should be.
This only happens when setting the wallpaper mid-session, upon logging in, or after killing
pcmanfm-qt(causing it to be restarted by LXQt) the wallpaper is set properly.Possible Solution
Steps to Reproduce (for bugs)
Context
System Information
Note: using a Wayland session with labwc 0.8.1, scaling set to 1.5 using kanshi and left to 1.0 in LXQt settings
The text was updated successfully, but these errors were encountered: