Correct the parameter error

weekroom · weekroom · commit 61eab441a932 · 2025-04-25T11:58:13.000+08:00
diff --git a/examples/M5Core/i2sloopback/i2sloopback.ino b/examples/M5Core/i2sloopback/i2sloopback.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Core Basic v2.7+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -69,7 +69,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Core/player_sd/player_sd.ino b/examples/M5Core/player_sd/player_sd.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Core Basic v2.7+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -71,7 +71,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Core/player_spiffs/player_spiffs.ino b/examples/M5Core/player_spiffs/player_spiffs.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Core Basic v2.7+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -71,7 +71,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Core2/i2sloopback/i2sloopback.ino b/examples/M5Core2/i2sloopback/i2sloopback.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Core2 + Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -69,7 +69,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Core2/player_sd/player_sd.ino b/examples/M5Core2/player_sd/player_sd.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Core2+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -71,7 +71,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Core2/player_spiffs/player_spiffs.ino b/examples/M5Core2/player_spiffs/player_spiffs.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Core2+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -71,7 +71,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Cores3/i2sloopback/i2sloopback.ino b/examples/M5Cores3/i2sloopback/i2sloopback.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Cores3 + Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio: https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -69,7 +69,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Cores3/player_sd/player_sd.ino b/examples/M5Cores3/player_sd/player_sd.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Cores3+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -71,7 +71,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/examples/M5Cores3/player_spiffs/player_spiffs.ino b/examples/M5Cores3/player_spiffs/player_spiffs.ino
@@ -6,7 +6,7 @@
  * @Hardwares: M5Cores3+ Module Audio
  * @Dependent Library:
  * M5Unified@^0.2.5: https://github.com/m5stack/M5Unified
- * Module Audio:
+ * Module Audio:https://github.com/m5stack/M5Module-Audio
  */
 
 #include "M5Unified.h"
@@ -71,7 +71,7 @@ void setup()
             Serial.println(address, HEX);
         }
     }
-    device.begin(&Wire, SYS_I2C_SCL_PIN, SYS_I2C_SCL_PIN);
+    device.begin(&Wire, SYS_I2C_SDA_PIN, SYS_I2C_SCL_PIN);
     device.setHPMode(AUDIO_HPMODE_NATIONAL);
     device.setMICStatus(AUDIO_MIC_OPEN);
     device.setRGBBrightness(100);
diff --git a/src/audio_i2c.cpp b/src/audio_i2c.cpp
@@ -91,7 +91,7 @@ void AudioI2c::setHPMode(audio_hpmode_t mode)
 void AudioI2c::setRGBBrightness(uint8_t brightness)
 {
     if (brightness > 100) brightness = 100;
-    uint8_t reg = RGB_BRIGHTNESS;
+    uint8_t reg = RGB_LED_BRIGHTNESS;
     writeBytes(_addr, reg, (uint8_t *)&brightness, 1);
 }
 
@@ -148,7 +148,7 @@ uint8_t AudioI2c::getHPInsertStatus()
 uint8_t AudioI2c::getRGBBrightness()
 {
     uint8_t data;
-    uint8_t reg = RGB_BRIGHTNESS;
+    uint8_t reg = RGB_LED_BRIGHTNESS;
     readBytes(_addr, reg, (uint8_t *)&data, 1);
     return data;
 }
diff --git a/src/audio_i2c.hpp b/src/audio_i2c.hpp
@@ -53,7 +53,7 @@
 /**S
  * @brief RGB LED Brightness Control Register (R/W)
  */
-#define RGB_BRIGHTNESS (0x30)
+#define RGB_LED_BRIGHTNESS (0x30)
 
 /**
  * @brief RGB LED Color Control Register (R/W)

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ void AudioI2c::setHPMode(audio_hpmode_t mode)`
`91`	`91`	`void AudioI2c::setRGBBrightness(uint8_t brightness)`
`92`	`92`	`{`
`93`	`93`	`if (brightness > 100) brightness = 100;`
`94`		`- uint8_t reg = RGB_BRIGHTNESS;`
	`94`	`+ uint8_t reg = RGB_LED_BRIGHTNESS;`
`95`	`95`	`writeBytes(_addr, reg, (uint8_t *)&brightness, 1);`
`96`	`96`	`}`
`97`	`97`
`@@ -148,7 +148,7 @@ uint8_t AudioI2c::getHPInsertStatus()`
`148`	`148`	`uint8_t AudioI2c::getRGBBrightness()`
`149`	`149`	`{`
`150`	`150`	`uint8_t data;`
`151`		`- uint8_t reg = RGB_BRIGHTNESS;`
	`151`	`+ uint8_t reg = RGB_LED_BRIGHTNESS;`
`152`	`152`	`readBytes(_addr, reg, (uint8_t *)&data, 1);`
`153`	`153`	`return data;`
`154`	`154`	`}`