import silently fails when opml XML is malformed #313

mblakele · 2014-12-11T17:16:17Z

Unexpected behavior: UI display "OPML import is happening. It can take a minute. Don't reorganize your feeds until it's completed importing. Refresh to see its progress." — but no feeds appear on refresh, or ever.

Expected behavior: UI displays an error message so the user can fix the problem and try again.

This test case should reproduce the problem. Note the unescaped quotes in attributes.

<?xml version="1.0"?>
<opml version="1.0">
  <head>
    <title>feeds export</title>
  </head>
  <body>
    <outline text="fubar "baz""
        title="fubar "baz"" type="rss"
        xmlUrl="https://example.com/feed"/>
</body>
</opml>

The text was updated successfully, but these errors were encountered:

This moves the initial XML parsing into the form submit request, then stores the resulting Opml object as a gob instead of storing the raw upload bytes. If the upload is malformed, the request response body includes a copy of the full error message. The ajaxform code will show this to the user as a new message. There may be some risk in moving work into the main request, because appengine likes requests to be low-latency. I think it's a reasonable tradeoff, in part because imports are relatively infrequest.

#313 show message when user submits bad OPML

maddyblue added a commit that referenced this issue Dec 16, 2014

Merge pull request #318 from mblakele/313-bad-opml

afcbf9e

#313 show message when user submits bad OPML

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

import silently fails when opml XML is malformed #313

import silently fails when opml XML is malformed #313

mblakele commented Dec 11, 2014

import silently fails when opml XML is malformed #313

import silently fails when opml XML is malformed #313

Comments

mblakele commented Dec 11, 2014