Double Dash .baa support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just use GetInstrument here, inside the try/catch, instead of doing both and also trying to set the patch separately?
We don't generate waveforms, but it's nice to know what settings and duty cycles to use for instruments for e.g. an NES VST plugin. Also include instrument names in VGMColl, and spit out instruments that have no regions, because the name is still helpful.
More Basic Siiva Cleanups
This seems to be a good old-fashioned typo. Spotted when trying to get WarioWare: Smooth Moves to work.
This also requires a C string so we don't need to duplicate the strlen() everywhere.
This gets basic RBNK and RSEQ data working yet. I still have to figure out RBNK in more detail for things like ADSR envelopes.
It seems somehow the parsing we're doing is causing Wild World to go into an infinite loop. This needs more investigation, but for now...
Reads from BMS files and is able to hopefully spit out a small amount of meaningful information from their existence.
We set it to -1 by default and test against that. It shouldn't go above 0x7F either so an int8_t should hold it.
We often see the same RWAR with different RBNKs, so only construct them once.
PCM8 is signed
Otherwise it would try to be guessed from the header sizes, not the data sizes, and we could get wrong offsets here
As seen in Bomberman.
It takes a long time because it linearly scans for every item for every position. Let's hack it out for now.
DLS Level 1 only supports mono samples
I can't figure out why this *2 is here, and it was screwing up Release metadata for SF2 files as verified in Awave Studio.
Why we have two name fields I don't know but name is shown in the UI so it's strange it's not exported as the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was fiddling around with the .aaf and .baa banks from Super Mario Galaxy & Sunshine. They seem to load and save as sf2 but when I try it with Mario Kart Double Dash, it gives me an error. Is there a way to fix this issue?