Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid SKU Handling for Linked Products in Magento #39329

Open
1 of 5 tasks
Syamsg opened this issue Nov 5, 2024 · 5 comments · May be fixed by #39333
Open
1 of 5 tasks

Invalid SKU Handling for Linked Products in Magento #39329

Syamsg opened this issue Nov 5, 2024 · 5 comments · May be fixed by #39333
Assignees
@Syamsg
Labels
Area: Product Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Syamsg
Copy link

Syamsg commented Nov 5, 2024

Preconditions and environment

  • Magento version 2.4.x

Steps to reproduce

  1. Create a New Product:

    • Navigate to Catalog > Products.
    • Click on Add Product.
    • Fill in the necessary details, and in the SKU field, enter 0.
    • Save the product.

  2. Edit an Existing Product:

    • Go back to Catalog > Products.
    • Choose any existing product you wish to link the previously created product to.
    • Scroll down to the Linked Products section (Related Products, Up-Sells, or Cross-Sells).

  3. Add the Product with SKU "0":

    • In the linked products section, search for the product you created with the SKU of 0.
    • Add this product as a linked product.

  4. Save the Main Product:

    • Click on Save to save the changes made to the main product.

  5. Observe the Error:

    • After attempting to save, an error message will appear: "The linked product SKU is invalid. Verify the data and try again."
      image

image

Expected result

The system should allow the linking of the product with a SKU of "0" without throwing an error, or it should prevent saving a product with "0" as a SKU outright.

Actual result

The system throws an error stating that the linked product SKU is invalid, preventing any changes to the product.

Additional information

This issue arises in the file Magento\Catalog\Model\ProductLink\Repository, specifically in the public function save, where the following condition is used:

if (!$entity->getLinkedProductSku()) {
    throw new NoSuchEntityException(__('The linked product SKU is invalid. Verify the data and try again.'));
}

One approach to resolve this is by adding an explicit check for the SKU value to prevent saving it as "0." For instance, you could add a validation condition to prevent saving a SKU as "0" at the time of saving the product.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 5, 2024

Hi @Syamsg. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 5, 2024
@engcom-Bravo engcom-Bravo self-assigned this Nov 5, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 5, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 5, 2024
@engcom-Bravo
Copy link
Contributor

Hi @Syamsg,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Bundle-Products-Inventory-Catalog-Magento-Admin-11-06-2024_09_37_AM

The system throws an error stating that the linked product SKU is invalid, preventing any changes to the product.

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Ui Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Area: Product labels Nov 6, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-13311 is successfully created for this GitHub issue.

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Nov 6, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@Syamsg Syamsg linked a pull request Nov 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Syamsg Syamsg

Labels
Area: Product Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue-39329-Invalid SKU Handling for Linked Products in Magento Syamsg/magento2
3 participants
@engcom-Bravo @github-jira-sync-bot @Syamsg