Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Correct colspan in visual swatch admin #39360

Open
2 of 5 tasks
m2-assistant bot opened this issue Nov 12, 2024 · 0 comments · May be fixed by #39359
Open
2 of 5 tasks

[Issue] Correct colspan in visual swatch admin #39360

m2-assistant bot opened this issue Nov 12, 2024 · 0 comments · May be fixed by #39359
Assignees
Labels
Issue: ready for confirmation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 12, 2024

This issue is automatically created based on existing pull request: #39359: Correct colspan in visual swatch admin


Description (*)

The colspan is incorrect. Probably based on the text.phtml file, but there is only 1 th per store + 4 additional, as you can see in the code.

Manual testing scenarios (*)

Edit a visual swatch and look at the tfoot of the swatches table. The number does not match the number of columns if the number of storeviews is > 1 . For 1 storeview, the number still matches (1 * 2 + 3 = 5 and 1 + 4 = 5), but otherwise it will be too high.

(As far as I can tell, this doesn't have any effect because the number of stores is at least 1 so the colspan will always be high

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Nov 12, 2024 that will close this issue
6 tasks
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 12, 2024
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Nov 12, 2024
@m2-community-project m2-community-project bot added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: ready for confirmation Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
Status: Ready for Confirmation
Development

Successfully merging a pull request may close this issue.

2 participants