From 2a24171191914e7a70473d74485101d8ee62f182 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Corr=C3=AAa=20Gomes?= Date: Wed, 20 Sep 2023 13:41:41 -0400 Subject: [PATCH 1/3] DevContainer > Node 14 to 18 LTS --- .devcontainer/devcontainer.json | 5 ++++- .vscode/settings.json | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 .vscode/settings.json diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 1c02faa9e5..c3c1c82593 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,6 +1,9 @@ { "name": "PWA Studio", - "image": "mcr.microsoft.com/devcontainers/javascript-node:0-14", + "image": "mcr.microsoft.com/devcontainers/javascript-node:0-18", + "containerEnv": { + "NODE_OPTIONS": "--openssl-legacy-provider" + }, "forwardPorts": [10000], "postCreateCommand": "yarn install --frozen-lockfile && yarn build && yarn workspace @magento/venia-concept run watch", "extensions": [ diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 0000000000..c48c9b97af --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,5 @@ +{ + "githubPullRequests.ignoredPullRequestBranches": [ + "develop" + ] +} \ No newline at end of file From 510ef1190502b7275666f2992dc57e03bb7d302c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Corr=C3=AAa=20Gomes?= Date: Wed, 20 Sep 2023 13:52:44 -0400 Subject: [PATCH 2/3] Delete .vscode directory --- .vscode/settings.json | 5 ----- 1 file changed, 5 deletions(-) delete mode 100644 .vscode/settings.json diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index c48c9b97af..0000000000 --- a/.vscode/settings.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "githubPullRequests.ignoredPullRequestBranches": [ - "develop" - ] -} \ No newline at end of file From 724e1775714872c5b4d74f03b53dca96bf07da75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafael=20Corr=C3=AAa=20Gomes?= Date: Fri, 5 Apr 2024 12:19:24 -0400 Subject: [PATCH 3/3] Update devcontainer.json --- .devcontainer/devcontainer.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index c3c1c82593..f7ffe27432 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -5,7 +5,8 @@ "NODE_OPTIONS": "--openssl-legacy-provider" }, "forwardPorts": [10000], - "postCreateCommand": "yarn install --frozen-lockfile && yarn build && yarn workspace @magento/venia-concept run watch", + "postCreateCommand": "yarn install --frozen-lockfile && yarn build", + "postStartCommand": "yarn workspace @magento/venia-concept run watch", "extensions": [ "larsroettig.vscode-pwa-studio", "GraphQL.vscode-graphql-syntax"