Skip to content

Commit bfd8260

Browse files
Fix loginWithPopupV2 implementation to use Verify method
Co-Authored-By: [email protected] <[email protected]>
1 parent 4b31d51 commit bfd8260

File tree

4 files changed

+16
-8
lines changed

4 files changed

+16
-8
lines changed

packages/@magic-ext/react-native-bare-oauth/src/index.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
OAuthRedirectConfiguration,
99
OAuthRedirectError,
1010
OAuthRedirectResult,
11+
OAuthRedirectStartResult,
1112
} from './types';
1213

1314
export class OAuthExtension extends Extension.Internal<'oauth'> {
@@ -155,10 +156,12 @@ export function getResult(this: OAuthExtension, queryString: string) {
155156
// Remove the save OAuth state from storage, it stays in memory now...
156157
this.utils.storage.removeItem(OAUTH_REDIRECT_METADATA_KEY);
157158

158-
const parseRedirectResult = this.utils.createJsonRpcRequestPayload(OAuthPayloadMethods.ParseRedirectResult, [
159-
queryString,
160-
verifier,
161-
state,
159+
const parseRedirectResult = this.utils.createJsonRpcRequestPayload(OAuthPayloadMethods.Verify, [
160+
{
161+
authorizationResponseParams: queryString,
162+
magicApiKey: this.sdk.apiKey,
163+
platform: 'rn',
164+
},
162165
]);
163166

164167
// Parse the result, which may contain an OAuth-formatted error.

packages/@magic-ext/react-native-bare-oauth/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { MagicUserMetadata } from '@magic-sdk/types';
33
export enum OAuthPayloadMethods {
44
ParseRedirectResult = 'magic_oauth_parse_redirect_result',
55
Start = 'magic_oauth_login_with_redirect_start',
6+
Verify = 'magic_oauth_login_with_redirect_verify',
67
}
78

89
export type OAuthProvider =

packages/@magic-ext/react-native-expo-oauth/src/index.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import {
88
OAuthRedirectConfiguration,
99
OAuthRedirectError,
1010
OAuthRedirectResult,
11+
OAuthRedirectStartResult,
1112
} from './types';
1213

1314
export class OAuthExtension extends Extension.Internal<'oauth'> {
@@ -155,10 +156,12 @@ export function getResult(this: OAuthExtension, queryString: string) {
155156
// Remove the save OAuth state from storage, it stays in memory now...
156157
this.utils.storage.removeItem(OAUTH_REDIRECT_METADATA_KEY);
157158

158-
const parseRedirectResult = this.utils.createJsonRpcRequestPayload(OAuthPayloadMethods.ParseRedirectResult, [
159-
queryString,
160-
verifier,
161-
state,
159+
const parseRedirectResult = this.utils.createJsonRpcRequestPayload(OAuthPayloadMethods.Verify, [
160+
{
161+
authorizationResponseParams: queryString,
162+
magicApiKey: this.sdk.apiKey,
163+
platform: 'rn',
164+
},
162165
]);
163166

164167
// Parse the result, which may contain an OAuth-formatted error.

packages/@magic-ext/react-native-expo-oauth/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { MagicUserMetadata } from '@magic-sdk/types';
33
export enum OAuthPayloadMethods {
44
ParseRedirectResult = 'magic_oauth_parse_redirect_result',
55
Start = 'magic_oauth_login_with_redirect_start',
6+
Verify = 'magic_oauth_login_with_redirect_verify',
67
}
78

89
export type OAuthProvider =

0 commit comments

Comments
 (0)