-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An edge being drawn looks awkward for non-normal edges #307
Labels
Comments
magjac
added a commit
to magjac/graphviz-visual-editor
that referenced
this issue
Feb 17, 2024
A drawn edge was always inserted into the DOT source as a directed edge ('->') instead of an undirectet edge ('--'), even if the graph was undirected. This resulted in syntax error in line <n> near '->'. Fixes #237. Note that, while being drawn, the edge is still shown with a normal arrowhead even though once inserted, it will have the arrowhead defined by the DOT source (explicitly or implicitly). This is due to magjac/d3-graphviz#307.
magjac
added a commit
to magjac/graphviz-visual-editor
that referenced
this issue
Feb 17, 2024
A drawn edge was always inserted into the DOT source as a directed edge ('->') instead of an undirectet edge ('--'), even if the graph was undirected. This resulted in syntax error in line <n> near '->'. Fixes #237. Note that, while being drawn, the edge is still shown with a normal arrowhead even though once inserted, it will have the arrowhead defined by the DOT source (explicitly or implicitly). This is due to magjac/d3-graphviz#307.
magjac
added a commit
to magjac/graphviz-visual-editor
that referenced
this issue
Feb 18, 2024
A drawn edge was always inserted into the DOT source as a directed edge ('->') instead of an undirectet edge ('--'), even if the graph was undirected. This resulted in syntax error in line <n> near '->'. Fixes #237. Note that, while being drawn, the edge is still shown with a normal arrowhead even though once inserted, it will have the arrowhead defined by the DOT source (explicitly or implicitly). This is due to magjac/d3-graphviz#307.
magjac
added a commit
to magjac/graphviz-visual-editor
that referenced
this issue
Feb 18, 2024
A drawn edge was always inserted into the DOT source as a directed edge ('->') instead of an undirected edge ('--'), even if the graph was undirected. This resulted in syntax error in line <n> near '->'. Fixes #237. Note that, while being drawn, the edge is still shown with a normal arrowhead also in undirected graphs. This is due to magjac/d3-graphviz#307. Once inserted however, it will have the correct arrowhead as defined by the DOT source (explicitly or implicitly).
magjac
added a commit
to magjac/graphviz-visual-editor
that referenced
this issue
Feb 18, 2024
A drawn edge was always inserted into the DOT source as a directed edge ('->') instead of an undirected edge ('--'), even if the graph was undirected. This resulted in syntax error in line <n> near '->'. Fixes #237. Note that, while being drawn, the edge is still shown with a normal arrowhead also in undirected graphs. This is due to magjac/d3-graphviz#307. However, once inserted into the DOT source, it will have the correct arrowhead as defined by the DOT source (explicitly or implicitly).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementation assumes an edge with
dir=forward
,arrowhead=normal
(explicit or implicit as for directed graphs) andarrowtail=none
. If this is not the case, the edge shown during drawing with drawEdge and updateDrawnEdge might look awkward.Once inserted with insertDrawnEdge the edge will have the specified attributes and look as specified.
Example
DOT source
digraph { a b }
JavaScript attributes
Graph during drawing the edge
The text was updated successfully, but these errors were encountered: