Skip to content

feat: allow phpunit 11 and 12 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: allow phpunit 11 and 12 #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc80494
feat: allow phpunit 11 and 12
Chris8934 Nov 1, 2025
65302a0
feat: allow phpunit 11 and 12
Chris8934 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"friendsofphp/php-cs-fixer": "^3.34",
"laravel/framework": "^10.0|^11.0",
"phpstan/phpstan": "^1.10",
"phpunit/phpunit": "^10.4",
"phpunit/phpunit": "^10.5.58 || ^11.5.43 || ^12.4.2",
Copy link
Member

@SimonMellerin SimonMellerin Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain us why you choose those specifics versions ?

--

I saw that you already make several PRs, thank you, but,

In general, could you give us some context when you create a PR?

Say ‘Hello’, explain what you update and why. I could make our review process more efficient and more pleasant.

Thanks!

Copy link
Contributor Author

@Chris53897 Chris53897 Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
My main goal is to use your Bundle with PHP 8.5 and Symfony 8.
This PHPUnit versions are the latest from there branch. Minior version often fix deprecations and it is easier to make stricter ci green. I do not know why ci breaks.
Support of wider PHPUnit version often helps to update other libraries as well.

"symfony/dependency-injection": "^6.0|^7.0",
"symfony/framework-bundle": "^6.0|^7.0",
"symfony/password-hasher": "^6.0|^7.0",
Expand Down
2 changes: 1 addition & 1 deletion phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" backupGlobals="false" colors="true" bootstrap="vendor/autoload.php" cacheDirectory=".phpunit.cache">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" backupGlobals="false" colors="true" bootstrap="./tests/bootstrap.php" cacheDirectory=".phpunit.cache">
<php>
<ini name="error_reporting" value="-1"/>
<env name="DBAL_DRIVER" value=""/>
Expand Down
19 changes: 19 additions & 0 deletions tests/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<?php

declare(strict_types=1);

use Symfony\Component\ErrorHandler\ErrorHandler;

ErrorHandler::register(null, false);

if (!($loader = @include __DIR__ . '/../vendor/autoload.php')) {
echo <<<'EOT'
You need to install the project dependencies using Composer:
$ wget https://getcomposer.org/composer.phar
OR
$ curl -s https://getcomposer.org/installer | php
$ php composer.phar install --dev
$ phpunit
EOT;
exit(1);
}
Loading