Fix selected layers in screenshot (#341)

* fix tests

* fix restoration layers context

* add changelog entry

* fix filter context restoration

* add changelog entry

* improve code quality

* improve Javascript quality code

* Update CHANGES.md

* improve js code quality

* fix restoration layers context

* add language in mapentity url for screamshotter

* fix quality

* change entry in changelog

* add tests

* Update fullurl in test_views.py for testing

* improve map_capture tests

* fix quality

Author: PartyNell

CHANGES.md

@@ -7,6 +7,8 @@ CHANGELOG
 **Bug fixes**
 
 - Fix filter context restoration
+- Fix layer restoration in screenshot
+
 
 8.14.5     (2025-10-30)
 -----------------------

mapentity/views/base.py

@@ -13,6 +13,7 @@
 from django.shortcuts import get_object_or_404
 from django.urls import reverse
 from django.utils import timezone
+from django.utils.translation import get_language
 from django.views import View, static
 from django.views.decorators.csrf import csrf_exempt
 from django.views.decorators.http import require_http_methods
@@ -189,9 +190,7 @@ def map_screenshot(request):
         context["print"] = True
         printcontext = json.dumps(context)
         contextencoded = quote(printcontext)
-        map_url += (
-            f"?auth_token={TokenManager.generate_token()}&context={contextencoded}"
-        )
+        map_url += f"?lang={get_language()}&auth_token={TokenManager.generate_token()}&context={contextencoded}"
 
         msg = f"Capture {map_url}"
         logger.debug(msg)

test_project/test_app/tests/test_views.py

@@ -1,3 +1,4 @@
+import json
 import os
 from unittest import mock
 
@@ -11,7 +12,9 @@
 from django.core.management import call_command
 from django.test import RequestFactory, TestCase
 from django.test.utils import override_settings
+from django.urls import reverse
 from django.utils.encoding import force_str
+from django.utils.translation import get_language
 from faker import Faker
 from faker.providers import geo
 from freezegun import freeze_time
@@ -666,3 +669,72 @@ def test_filter_view_creates_full_generic_filter(self):
         response = self.client.get(City.get_filter_url())
         self.assertContains(response, '<input type="text" name="name"')
         self.assertContains(response, '<input type="hidden" name="bbox"')
+
+
+class MapScreenshotTest(BaseTest):
+    context = {
+        "mapview": {"lat": 42.771211138625894, "lng": 1.336212158203125, "zoom": 9},
+        "maplayers": ["OSM", "Cadastre", "Signalétiques", "POI", "▣ Tronçons"],
+        "filter": "",
+        "sortcolumns": {},
+        "fullurl": "https://test.fr/path/list/",
+        "url": "/path/list/",
+        "selector": "#map",
+        "viewport": {"width": 1854, "height": 481},
+        "timestamp": 1762525783907,
+    }
+
+    @mock.patch("mapentity.helpers.requests.get")
+    def test_map_screenshot_success(self, mock_capture):
+        self.login()
+
+        mock_capture.return_value.content = b"fake_png_data"
+        mock_capture.return_value.status_code = 200
+
+        data = {"printcontext": json.dumps(self.context)}
+
+        response = self.client.post(reverse("mapentity:map_screenshot"), data)
+
+        self.assertEqual(response.status_code, 200)
+        self.assertEqual(response["Content-Type"], "image/png")
+        self.assertIn("attachment", response["Content-Disposition"])
+        self.assertEqual(response.content, b"fake_png_data")
+
+        args, kwargs = mock_capture.call_args
+        called_url = args[0]
+
+        # check mapentity url
+        self.assertTrue(called_url.startswith("http"))
+        self.assertIn(f"lang%3D{get_language()}", called_url)
+        self.assertIn("auth_token", called_url)
+        self.assertIn("context", called_url)
+
+        # check screamshotter url
+        self.assertIn("width=1854", called_url)
+        self.assertIn("height=481", called_url)
+        self.assertIn("selector=%23map", called_url)
+
+    def test_map_screenshot_invalid_json_context(self):
+        self.login()
+
+        data = {"printcontext": "json_error"}
+
+        with self.assertLogs(level="INFO") as cm:
+            response = self.client.post(reverse("mapentity:map_screenshot"), data)
+        self.assertEqual(response.status_code, 400)
+        self.assertIn(
+            "ERROR:mapentity.views.base:Expecting value: line 1 column 1 (char 0)",
+            cm.output[0],
+        )
+
+    def test_map_screenshot_invalid_length_context(self):
+        self.login()
+
+        data = {"printcontext": "{" + "test" * 1000 + "}"}
+
+        with self.assertLogs(level="INFO") as cm:
+            response = self.client.post(reverse("mapentity:map_screenshot"), data)
+        self.assertEqual(response.status_code, 400)
+        self.assertIn(
+            "ERROR:mapentity.views.base:Print context is way too big", cm.output[0]
+        )