-
Notifications
You must be signed in to change notification settings - Fork 21
Fix selected layers in screenshot #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+76
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 90.94% 91.84% +0.90%
==========================================
Files 33 33
Lines 2452 2453 +1
==========================================
+ Hits 2230 2253 +23
+ Misses 222 200 -22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
71d7e11 to
cf81adb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When taking a screenshot of the map, some layers were not correctly displayed.
This happened because the user interface language (e.g. French, Spanish, etc.) differed from the language used by the headless browser in Screamshotter, which defaults to English. As a result, the application context could not be properly restored due to the language mismatch.
This PR introduces a new lang parameter in the application URL.
It allows Screamshotter to explicitly specify the language to use when loading the application, ensuring that the context is restored consistently across languages.
Related Issue