Skip to content

Conversation

@PartyNell
Copy link
Contributor

@PartyNell PartyNell commented Nov 3, 2025

Description

When taking a screenshot of the map, some layers were not correctly displayed.
This happened because the user interface language (e.g. French, Spanish, etc.) differed from the language used by the headless browser in Screamshotter, which defaults to English. As a result, the application context could not be properly restored due to the language mismatch.
This PR introduces a new lang parameter in the application URL.
It allows Screamshotter to explicitly specify the language to use when loading the application, ensuring that the context is restored consistently across languages.

Related Issue

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.84%. Comparing base (fdb4728) to head (4100e9a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   90.94%   91.84%   +0.90%     
==========================================
  Files          33       33              
  Lines        2452     2453       +1     
==========================================
+ Hits         2230     2253      +23     
+ Misses        222      200      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PartyNell PartyNell requested a review from submarcos November 3, 2025 10:41
@PartyNell PartyNell changed the base branch from master to fix_test_content_type November 5, 2025 09:04
@PartyNell PartyNell force-pushed the fix_restore_layers_context branch from 71d7e11 to cf81adb Compare November 5, 2025 09:16
Base automatically changed from fix_test_content_type to master November 5, 2025 10:16
@PartyNell PartyNell changed the base branch from master to fix_restore_filter_context November 6, 2025 10:17
@PartyNell PartyNell changed the title Fix the restore layers context Fix layers restoration in screenshot Nov 7, 2025
Base automatically changed from fix_restore_filter_context to master November 12, 2025 15:10
@PartyNell PartyNell changed the title Fix layers restoration in screenshot Fix selected layers in screenshot Nov 12, 2025
@PartyNell PartyNell merged commit fe038ee into master Nov 13, 2025
12 checks passed
@PartyNell PartyNell deleted the fix_restore_layers_context branch November 13, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants