Skip to content

Commit 2edd01d

Browse files
committed
Ignore packages signatures when using resolvo for now
Signed-off-by: Julien Jerphanion <[email protected]>
1 parent 2e715be commit 2edd01d

File tree

2 files changed

+28
-26
lines changed

2 files changed

+28
-26
lines changed

libmamba/src/solver/resolvo/database.cpp

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -113,19 +113,20 @@ namespace mamba::solver::resolvo
113113
.or_else([](specs::ParseError&& err) { throw std::move(err); })
114114
.value();
115115

116-
auto signatures = [&]
117-
{
118-
auto maybe_sigs = repodata_doc["signatures"];
119-
if (!maybe_sigs.error() && verify_artifacts)
120-
{
121-
return std::make_optional(maybe_sigs);
122-
}
123-
else
124-
{
125-
LOG_DEBUG << "No signatures available or requested. Downloading without verifying artifacts.";
126-
return decltype(std::make_optional(maybe_sigs)){};
127-
}
128-
}();
116+
// TODO: it does not seems resolvo can handle setting signatures on solvables for now
117+
// auto signatures = [&]
118+
// {
119+
// auto maybe_sigs = repodata_doc["signatures"];
120+
// if (!maybe_sigs.error() && verify_artifacts)
121+
// {
122+
// return std::make_optional(maybe_sigs);
123+
// }
124+
// else
125+
// {
126+
// LOG_DEBUG << "No signatures available or requested. Downloading without verifying
127+
// artifacts."; return decltype(std::make_optional(maybe_sigs)){};
128+
// }
129+
// }();
129130

130131
// Process packages.conda first
131132
if (auto pkgs = repodata_doc["packages.conda"]; !pkgs.error())

libmamba/tests/src/solver/resolvo/test_solver.cpp

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -767,19 +767,20 @@ parse_repodata_json(
767767
.or_else([](specs::ParseError&& err) { throw std::move(err); })
768768
.value();
769769

770-
auto signatures = [&]
771-
{
772-
auto maybe_sigs = repodata["signatures"];
773-
if (!maybe_sigs.error() && verify_artifacts)
774-
{
775-
return std::make_optional(maybe_sigs);
776-
}
777-
else
778-
{
779-
LOG_DEBUG << "No signatures available or requested. Downloading without verifying artifacts.";
780-
return decltype(std::make_optional(maybe_sigs)){};
781-
}
782-
}();
770+
// TODO: it does not seems resolvo can handle setting signatures on solvables for now
771+
// auto signatures = [&]
772+
// {
773+
// auto maybe_sigs = repodata["signatures"];
774+
// if (!maybe_sigs.error() && verify_artifacts)
775+
// {
776+
// return std::make_optional(maybe_sigs);
777+
// }
778+
// else
779+
// {
780+
// LOG_DEBUG << "No signatures available or requested. Downloading without verifying
781+
// artifacts."; return decltype(std::make_optional(maybe_sigs)){};
782+
// }
783+
// }();
783784

784785
// Process packages.conda first
785786
if (auto pkgs = repodata["packages.conda"]; !pkgs.error())

0 commit comments

Comments
 (0)