run_script not called for pre-unlink scripts

[alexc5589]

run_script is called for post-link scripts but despite the comment in the code and the docs describing similar for pre-unlink there is no call present and thus pre-unlink scripts are not executed.

Is this a bug/oversight or by design?

Thanks!

[Hind-M]

Hey @alexc5589! Can you please point to the code and the docs you're referring to? Thanks!

[alexc5589]

Yeah sure, thanks for the reply.

The docs I'm referring to are the conda description of link scripts, here https://docs.conda.io/projects/conda-build/en/stable/resources/link-scripts.html

The comment in the code I'm referring to is the comment on the run_script function, here https://github.com/mamba-org/mamba/blob/main/libmamba/src/core/link.cpp#L314.

It looks like the intention was to call this function before unlinking.

Cheers

[Hind-M]

As far as I can tell, it looks like the run_script function was indeed intended to be called with pre-unlink, so it might have simply been overlooked. To confirm this, we would need a use case where we expect the pre-unlink scripts to run, to ensure it behaves as it should (and come up with the corresponding tests - note that there are no tests for post-link either at the moment).
Can you please share the details of your use case if possible?
Thanks!

[alexc5589]

My use case involves creating a symlink during post-link which is then cleaned up during pre-unlink. This is for systemd integration. Perhaps not the simplest example, I'm sure we can find some others in existing packages.