fix bug on update_package.py #1162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update comments on update_package.py add comments that help understand the issue that the latest sclauncher doesn't get updated. The version from the regex (current version) didn't include `v` however the function get_latest_version did include the `v`. The URL replaced the version without `v` (current version) with the latest version found that included the `v`, which resulted in the wrong URL `https://github.com/jstrosch/sclauncher/releases/download/vv0.0.6/sclauncher.exe`
Ana06
reviewed
Nov 12, 2024
| @@ -37,7 +37,10 @@ def get_latest_version(org, project, version): | |||
| print(f"GitHub API response not ok: {response.status_code}") | |||
| return None | |||
| latest_version = response.json()["tag_name"] | |||
| return latest_version | |||
| if latest_version.startswith('v'): | |||
There was a problem hiding this comment.
@naacbin introduced the support for packages whose version is preceded by v in #1067, but it seems the v was only taken into account when matching the url in the file and not to get the latest version, so it seems like the fix has never worked.
What is really getting me confused is that I see upx being correctly updated by our bot in acec181 before #1067, how is this possible? 🕵️♀️
| @@ -37,7 +37,10 @@ def get_latest_version(org, project, version): | |||
| print(f"GitHub API response not ok: {response.status_code}") | |||
| return None | |||
| latest_version = response.json()["tag_name"] | |||
| return latest_version | |||
| if latest_version.startswith('v'): | |||
| return latest_version.replace('v','',1) | |||
There was a problem hiding this comment.
A bit more elegant 😉
Suggested change
| return latest_version.replace('v','',1) | |
| return latest_version[1:] |
| @@ -104,6 +107,7 @@ def update_github_url(package): | |||
|
|
|||
| latest_version = None | |||
| for url, org, project, version in matches: | |||
| # version excludes `v` from the capturing group in the regex therefore latest_version_match mustn't include `v` if the version starts with `v` | |||
There was a problem hiding this comment.
Can you move this comment (maybe with a bit rewording needed) just before the line if latest_version.startswith('v'):? Here it is difficult to understand what it is refering to 😕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue #1142 for when --update-type is GITHUB_URL