Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Classic] Missing Tooltips for Header Navbar Icons #729

Closed
abhishek-exists opened this issue Aug 4, 2024 · 2 comments
Closed

[UI Classic] Missing Tooltips for Header Navbar Icons #729

abhishek-exists opened this issue Aug 4, 2024 · 2 comments
Labels
Frontend (Classic) Related to svelte issues

Comments

@abhishek-exists
Copy link

Hi Team,

I have noticed that the icons in the header navbar are not displaying tooltips correctly; they are misaligned and do not have any values. Instead, hovering over them shows undefined.

Question: Do we need to implement tooltips for these icons @Sheepux?

If so, we can add the following code to fix this issue, Please let me know if you would like me to raise a PR to implement this fix!

Current behavior:
image
image
image

Expected behavior:
image
image
image

Lmk if you need a PR for this, Thanks

@abhishek-exists abhishek-exists changed the title [UI] [UI] Missing Tooltips for Header Navbar Icons Aug 4, 2024
@abhishek-exists abhishek-exists changed the title [UI] Missing Tooltips for Header Navbar Icons [UI Classic] Missing Tooltips for Header Navbar Icons Aug 4, 2024
@Sheepux
Copy link
Contributor

Sheepux commented Aug 4, 2024

All the UI issues you're mentionning are due to the carbon framework upgrade. I've been on pause for a few months, I'll adress it but i was also hopping they'd release the new carbon v11 for svelte (still ongoing)
But perhaps the WIP could be good enougth (i need to check what kind of component i'm using) carbon-design-system/carbon-components-svelte#1629
Edit: looks like there is a v1.0.0-next.1 https://next-carbon-components-svelte.onrender.com/components/UIShell

@Sheepux Sheepux added the Frontend (Classic) Related to svelte issues label Aug 5, 2024
@Sheepux
Copy link
Contributor

Sheepux commented Aug 5, 2024

Just found out, i did the changes before going on vacation ...
Also, when you've already done the job, just PR it ;) (i'm commiting mine)

@Sheepux Sheepux closed this as completed in 77f0f5e Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend (Classic) Related to svelte issues
Projects
None yet
Development

No branches or pull requests

2 participants