Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode build phase script improvements #173

Open
2 tasks
IodaMikeMapbox opened this issue Jul 24, 2019 · 0 comments
Open
2 tasks

Xcode build phase script improvements #173

IodaMikeMapbox opened this issue Jul 24, 2019 · 0 comments
Labels
iOS nostale ignored by stalebot P2 Implement with spare resource

Comments

@IodaMikeMapbox
Copy link
Contributor

IodaMikeMapbox commented Jul 24, 2019

Description

Our build phase has a script for copying frameworks, that script has a room for improvements, for now we noticed. At least:

  • use set -euo pipefail as a general setup;
  • check presence of arguments if it's required;
  • add comprehensive comments, because for now it's not clear at first sight what is going on;
  • etc.

More useful notes about script improvements can be found in the pr.

Goal

Improve xcode build phase script.

Steps

  • Improve the script;
  • Tested and acceptance criteria is matched (result matches the goal).
@IodaMikeMapbox IodaMikeMapbox added iOS P2 Implement with spare resource labels Jul 24, 2019
@vladzima vladzima added the nostale ignored by stalebot label Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS nostale ignored by stalebot P2 Implement with spare resource
Projects
None yet
Development

No branches or pull requests

2 participants