Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision SDK should notify delegate when replay video finishes #231

Open
avi-c opened this issue Sep 17, 2019 · 4 comments
Open

Vision SDK should notify delegate when replay video finishes #231

avi-c opened this issue Sep 17, 2019 · 4 comments
Assignees
Labels
staled marked by stalebot according to config User Feedback

Comments

@avi-c
Copy link

avi-c commented Sep 17, 2019

Description

VisionReplayManager does not notify the delegate when replay finishes. This presents a problem for the delegate since it will not know if the replay manager state is start or stop.

For example, if I am using the replay manager to replay a nav session in Apex, I need to stop the replay manager if the user hits the "end" button. However, if the replay runs all the way through to the end before the user hits End, then if I try to stop the replay then I will crash since the replay manager throws an exception if the replay manager is told to stop when it is not playing.

@vladzima
Copy link
Contributor

Thanks for the report @avi-c

@avi-c
Copy link
Author

avi-c commented Sep 17, 2019

Without this knowledge, I won't know if it's safe to call stop() on the replay manager or if calling it will lead to a crash.

@stale
Copy link

stale bot commented Nov 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the staled marked by stalebot according to config label Nov 1, 2019
@vladzima
Copy link
Contributor

Is this still valid? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staled marked by stalebot according to config User Feedback
Projects
None yet
Development

No branches or pull requests

3 participants