Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race in serve_rendered.js together with serveAllStyles #511

Open
xabbu42 opened this issue Jan 5, 2021 · 0 comments · May be fixed by #512
Open

race in serve_rendered.js together with serveAllStyles #511

xabbu42 opened this issue Jan 5, 2021 · 0 comments · May be fixed by #512

Comments

@xabbu42
Copy link
Contributor

xabbu42 commented Jan 5, 2021

There is a small race in serve_rendered.js as it returns a promise accessing the passed repo hash. But when the code is actually executed the the key in repo could already be removed again. I managed to trigger this in branch of mine which seemed to slow down stuff at startup enough that this together with the way serveAllStyles handles change events (by removing and readding styles) let the server crash.

@xabbu42 xabbu42 linked a pull request Jan 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant