Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider re-implementing as a Leaflet plugin. #7

Open
louh opened this issue Jun 28, 2017 · 0 comments
Open

Consider re-implementing as a Leaflet plugin. #7

louh opened this issue Jun 28, 2017 · 0 comments

Comments

@louh
Copy link
Contributor

louh commented Jun 28, 2017

When this library was originally written, it was done in vanilla JS for the greatest amount of compatibility -- for instance, it could be used on demos that wasn't based on Leaflet. (See, for example, the demos on the Vector Tiles product page, only one of which is based on Leaflet.)

However, a Leaflet plugin could lead to some other benefits -- for instance, placing it within a Leaflet overlay container makes it easier to prevent situations where multiple UI components overlap each other because they are not aware of each other.

This would be a pretty considerable rewrite or augmentation of this library and may likely prevent it from working outside of a Leaflet context. This means there's a lot of work, and we lose something in the trade. I'm putting this issue here so that we have a point of reference to go off on should we start considering this in the future, not to suggest that we need to do this right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant