Skip to content

Truncated warning messages prevents user from fixing renamed options #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
novoid opened this issue Nov 29, 2024 · 5 comments
Open

Truncated warning messages prevents user from fixing renamed options #173

novoid opened this issue Nov 29, 2024 · 5 comments
Labels
bug Something isn't working output

Comments

@novoid
Copy link

novoid commented Nov 29, 2024

Hi,

I'm using https://github.com/viperML/nh which is using this project to render screen output.

I currently do have following warning messages:

Screenshot_2024-11-29_18-27-33 nh output of renamed stuff

I think it is clearly visible that truncating those messages do render them useless because I can't see what the new names are which is the second most important part of those warnings.

To mitigate this bug, I'd probably not truncate the lines but use some sort of word wrap.

(FYI: I was able to locate the new names via https://search.nixos.org/options?channel=24.05&from=0&size=50&sort=relevance&type=packages&query=services.xserver.xkb and so forth. So the direct problem could be fixed in my config. The general issue remains to be fixed.)

Thanks!

@maralorn
Copy link
Owner

Huh, well. I see that this is unfortunate. On the other hand every line is valuable and wrapping warnings can quickly push out the log and the tree from the screen.

Do the warnings currently appear in the logs? That's the minimum we should do.

@novoid
Copy link
Author

novoid commented Nov 30, 2024

Where can I find logs that should contain the warnings?

As a mitigation, I can think of adding a hint (a command or a file link) in the "heading" line of the warnings. This teaches where to find the logs so that anybody is able to retrieve the long form without having to know the log source beforehand.

Otherwise, it reminds me of various jokes with: "... and the murder is ..." followed by some kind of interruption. 😉

@maralorn
Copy link
Owner

maralorn commented Dec 1, 2024

With logs I mean what is printed to the console right above the info box.
If the warnings don’t scroll through there we should fix that.

@novoid
Copy link
Author

novoid commented Dec 2, 2024

AFAIR those messages were not visible directly above the info box. I had to use the web browser to find out about the renamed variables.

@maralorn
Copy link
Owner

maralorn commented Dec 2, 2024

Okay, then lets print those to the terminal, that shouldn’t be hard and would make this issue far less problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working output
Projects
Status: Next
Development

No branches or pull requests

2 participants