fix: Only lookup once

Author: mrousavy

cpp/base/WKTJsiHostObject.cpp

@@ -49,10 +49,11 @@ void JsiHostObject::set(jsi::Runtime &rt, const jsi::PropNameID &name,
 jsi::Value JsiHostObject::get(jsi::Runtime &runtime,
                               const jsi::PropNameID &name) {
   auto nameStr = name.utf8(runtime);
+  auto& cache = _hostFunctionCache.get(runtime);
 
   // Check function cache
-  auto cachedFunc = _hostFunctionCache.get(runtime).find(nameStr);
-  if (cachedFunc != _hostFunctionCache.get(runtime).end()) {
+  auto cachedFunc = cache.find(nameStr);
+  if (cachedFunc != cache.end()) {
     return cachedFunc->second.asFunction(runtime);
   }
 
@@ -75,7 +76,7 @@ jsi::Value JsiHostObject::get(jsi::Runtime &runtime,
 
     // Add to cache - it is important to cache the results from the
     // createFromHostFunction function which takes some time.
-    return _hostFunctionCache.get(runtime)
+    return cache
         .emplace(nameStr, jsi::Function::createFromHostFunction(runtime, name,
                                                                 0, dispatcher))
         .first->second.asFunction(runtime);

cpp/base/WKTRuntimeAwareCache.h

@@ -80,7 +80,7 @@ class RuntimeAwareCache : public BaseRuntimeAwareCache,
         // we only add listener when the secondary runtime is used, this assumes
         // that the secondary runtime is terminated first. This lets us avoid
         // additional complexity for the majority of cases when objects are not
-        // shared between runtimes. Otherwise we'd have to register all objecrts
+        // shared between runtimes. Otherwise we'd have to register all objects
         // with the RuntimeMonitor as opposed to only registering ones that are
         // used in secondary runtime. Note that we can't register listener here
         // with the primary runtime as it may run on a separate thread.