Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset-password addon not included? #81

Open
marsbard opened this issue Jun 3, 2015 · 6 comments
Open

reset-password addon not included? #81

marsbard opened this issue Jun 3, 2015 · 6 comments

Comments

@marsbard
Copy link
Owner

marsbard commented Jun 3, 2015

maybe this got excluded at some point? I think the source manifest is still there as that's what I built the feature list from

@digcat
Copy link
Collaborator

digcat commented Jun 4, 2015

its in modules/deploy, we didnt find a way to auto deploy it, this might be something fixable in newer releases?

https://localhost:8080/share/page/modules/deploy

@marsbard
Copy link
Owner Author

marsbard commented Jun 4, 2015

@marsbard
Copy link
Owner Author

marsbard commented Jun 4, 2015

From Angel:

It’s needed an true at https://github.com/share-extras/reset-password-dialog/blob/master/config/alfresco/site-data/extensions/reset-password-module.xml

So maybe we can override this when we unpack it?

@digcat
Copy link
Collaborator

digcat commented Jun 4, 2015

other modules enable by default, is this by design?

@marsbard
Copy link
Owner Author

marsbard commented Jun 4, 2015

Yeah they probably set the extension.

but there was a bit more conversation in email:
Angel:

Regarding this issue (#81), because of reset-password-dialog addon has no “autodeploy” mark at extension declaration (https://github.com/share-extras/reset-password-dialog/blob/master/config/alfresco/site-data/extensions/reset-password-module.xml).

What we cand do? Modify this file once downloaded for Puppet or fork original project to include this directive? Or is there any other possibility?

Me:

To be honest I was thinking about enabling auto-deploy globally, I will need to find again where it is, I think it was in share-config.xml so could probably override in share-config-custom.xml

Angel:

This is the “other possibility” and I think is the good one ;-)

I think it is too, it's totally possible to turn this on and off per addon with the override as described but I can't see a use case, for us, which wouldn't want to see all modules autodeployed.

@marsbard
Copy link
Owner Author

marsbard commented Jun 4, 2015

pull requests welcome against this template:

https://github.com/marsbard/puppet-alfresco/blob/master/templates/share-config-custom.xml.erb

the only thing you need to know about templates is they are ruby ERB templates, you will see the non-templated parts stubbed out like <%= @share_host %> which will be replaced by the share_host variable in puppet (most of the important variables will be defined in manifests/init.pp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants