Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-contiguous arrays in rank-1 modifications #24

Open
marvinpfoertner opened this issue Aug 27, 2021 · 0 comments
Open

Support non-contiguous arrays in rank-1 modifications #24

marvinpfoertner opened this issue Aug 27, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@marvinpfoertner
Copy link
Owner

Currently, the rank-1 modifications cholupdates.rank_1.update_seeger and cholupdates.rank_1.downdate_seeger only support arrays which lie contiguous in memory.
This can be changed by reading the array strides from the numpy properties.
This will also get rid of the inelegant distinction between Fortran and C contiguous arrays, since we will consider general strides.
@marvinpfoertner marvinpfoertner added the enhancement New feature or request label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marvinpfoertner