Skip to content

Commit 0d57c25

Browse files
pubiqqpubiqq
committed
[Internal] Update naming of base styles
1 parent 52228c1 commit 0d57c25

File tree

10 files changed

+64
-189
lines changed

10 files changed

+64
-189
lines changed

‎lib/java/com/google/android/material/bottomsheet/res/values/themes_base.xml‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,37 +15,29 @@
1515
~ limitations under the License.
1616
-->
1717
<resources>
18-
<style name="Base.V14.Theme.Material3.Light.BottomSheetDialog" parent="Theme.Material3.Light.Dialog">
18+
<style name="Base.Theme.Material3.Light.BottomSheetDialog" parent="Theme.Material3.Light.Dialog">
1919
<item name="android:windowIsFloating">false</item>
2020
<item name="android:windowSoftInputMode">adjustResize</item>
2121
<item name="android:windowBackground">@android:color/transparent</item>
2222
<item name="android:windowAnimationStyle">@style/Animation.Material3.BottomSheetDialog</item>
2323
<item name="bottomSheetStyle">@style/Widget.Material3.BottomSheet.Modal</item>
2424
</style>
2525

26-
<style name="Base.V14.Theme.Material3.Dark.BottomSheetDialog" parent="Theme.Material3.Dark.Dialog">
26+
<style name="Base.Theme.Material3.Dark.BottomSheetDialog" parent="Theme.Material3.Dark.Dialog">
2727
<item name="android:windowIsFloating">false</item>
2828
<item name="android:windowSoftInputMode">adjustResize</item>
2929
<item name="android:windowBackground">@android:color/transparent</item>
3030
<item name="android:windowAnimationStyle">@style/Animation.Material3.BottomSheetDialog</item>
3131
<item name="bottomSheetStyle">@style/Widget.Material3.BottomSheet.Modal</item>
3232
</style>
3333

34-
<style name="Base.V14.ThemeOverlay.Material3.BottomSheetDialog" parent="Base.ThemeOverlay.Material3.Dialog">
34+
<style name="Base.ThemeOverlay.Material3.BottomSheetDialog" parent="Base.ThemeOverlay.Material3.Dialog">
35+
<item name="android:statusBarColor">@android:color/transparent</item>
3536
<item name="android:windowIsFloating">false</item>
3637
<item name="android:windowSoftInputMode">adjustResize</item>
3738
<item name="android:windowBackground">@android:color/transparent</item>
3839
<item name="android:windowAnimationStyle">@style/Animation.Material3.BottomSheetDialog</item>
3940
<item name="bottomSheetStyle">@style/Widget.Material3.BottomSheet.Modal</item>
4041
<item name="enableEdgeToEdge">true</item>
4142
</style>
42-
43-
<style name="Base.V21.ThemeOverlay.Material3.BottomSheetDialog"
44-
parent="Base.V14.ThemeOverlay.Material3.BottomSheetDialog">
45-
<item name="android:statusBarColor">@android:color/transparent</item>
46-
</style>
47-
48-
<style name="Base.Theme.Material3.Light.BottomSheetDialog" parent="Base.V14.Theme.Material3.Light.BottomSheetDialog"/>
49-
<style name="Base.Theme.Material3.Dark.BottomSheetDialog" parent="Base.V14.Theme.Material3.Dark.BottomSheetDialog"/>
50-
<style name="Base.ThemeOverlay.Material3.BottomSheetDialog" parent="Base.V21.ThemeOverlay.Material3.BottomSheetDialog"/>
5143
</resources>

‎lib/java/com/google/android/material/dialog/res/values-v24/themes_base.xml‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎lib/java/com/google/android/material/dialog/res/values/themes_base.xml‎

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@
1616
-->
1717
<resources xmlns:tools="http://schemas.android.com/tools">
1818

19-
<!-- All new attributes should be set in the follow four Base.V14 themes. -->
20-
<eat-comment/>
21-
22-
<style name="Base.V14.Theme.Material3.Light.Dialog" parent="Theme.MaterialComponents.Light.Dialog">
19+
<style name="Base.Theme.Material3.Light.Dialog" parent="Theme.MaterialComponents.Light.Dialog">
2320
<item name="isMaterial3Theme">true</item>
2421

2522
<!-- Color palettes -->
@@ -108,6 +105,7 @@
108105
<item name="collapsingToolbarLayoutStyle">@style/Widget.Material3.CollapsingToolbar</item>
109106
<item name="collapsingToolbarLayoutMediumStyle">@style/Widget.Material3.CollapsingToolbar.Medium</item>
110107
<item name="collapsingToolbarLayoutLargeStyle">@style/Widget.Material3.CollapsingToolbar.Large</item>
108+
<item name="android:contextPopupMenuStyle" tools:targetApi="n">@style/Widget.Material3.PopupMenu.ContextMenu</item>
111109
<item name="drawerLayoutStyle">@style/Widget.Material3.DrawerLayout</item>
112110
<item name="extendedFloatingActionButtonStyle">?attr/extendedFloatingActionButtonPrimaryStyle</item>
113111
<item name="extendedFloatingActionButtonPrimaryStyle">@style/Widget.Material3.ExtendedFloatingActionButton.Icon.Primary</item>
@@ -312,7 +310,7 @@
312310
<item name="dynamicColorThemeOverlay">@style/ThemeOverlay.Material3.DynamicColors.Light</item>
313311
</style>
314312

315-
<style name="Base.V14.Theme.Material3.Dark.Dialog" parent="Theme.MaterialComponents.Dialog">
313+
<style name="Base.Theme.Material3.Dark.Dialog" parent="Theme.MaterialComponents.Dialog">
316314
<item name="isMaterial3Theme">true</item>
317315

318316
<!-- Color palettes -->
@@ -401,6 +399,7 @@
401399
<item name="collapsingToolbarLayoutStyle">@style/Widget.Material3.CollapsingToolbar</item>
402400
<item name="collapsingToolbarLayoutMediumStyle">@style/Widget.Material3.CollapsingToolbar.Medium</item>
403401
<item name="collapsingToolbarLayoutLargeStyle">@style/Widget.Material3.CollapsingToolbar.Large</item>
402+
<item name="android:contextPopupMenuStyle" tools:targetApi="n">@style/Widget.Material3.PopupMenu.ContextMenu</item>
404403
<item name="drawerLayoutStyle">@style/Widget.Material3.DrawerLayout</item>
405404
<item name="extendedFloatingActionButtonStyle">?attr/extendedFloatingActionButtonPrimaryStyle</item>
406405
<item name="extendedFloatingActionButtonPrimaryStyle">@style/Widget.Material3.ExtendedFloatingActionButton.Icon.Primary</item>
@@ -603,9 +602,6 @@
603602
<item name="dynamicColorThemeOverlay">@style/ThemeOverlay.Material3.DynamicColors.Dark</item>
604603
</style>
605604

606-
<style name="Base.Theme.Material3.Light.Dialog" parent="Base.V14.Theme.Material3.Light.Dialog"/>
607-
<style name="Base.Theme.Material3.Dark.Dialog" parent="Base.V14.Theme.Material3.Dark.Dialog"/>
608-
609605
<style name="Base.Theme.Material3.Light.Dialog.FixedSize">
610606
<item name="windowFixedWidthMajor">@dimen/abc_dialog_fixed_width_major</item>
611607
<item name="windowFixedWidthMinor">@dimen/abc_dialog_fixed_width_minor</item>
@@ -620,7 +616,15 @@
620616
<item name="windowFixedHeightMinor">@dimen/abc_dialog_fixed_height_minor</item>
621617
</style>
622618

623-
<style name="Base.V14.Theme.MaterialComponents.Dialog" parent="Base.V14.Theme.MaterialComponents.Dialog.Bridge">
619+
<!-- Themes in the "Base.Theme" family vary based on the current platform
620+
version to provide the correct basis on each device. You probably don't
621+
want to use them directly in your apps.
622+
623+
Themes in the "Theme.MaterialComponents" family are meant to be extended or used
624+
directly by apps. -->
625+
<eat-comment/>
626+
627+
<style name="Base.Theme.MaterialComponents.Dialog" parent="Base.Theme.MaterialComponents.Dialog.Bridge">
624628
<item name="viewInflaterClass">com.google.android.material.theme.MaterialComponentsViewInflater</item>
625629

626630
<item name="colorPrimary">@color/design_dark_default_color_primary</item>
@@ -666,18 +670,15 @@
666670
<item name="toolbarStyle">@style/Widget.MaterialComponents.Toolbar</item>
667671

668672
<item name="alertDialogTheme">@style/ThemeOverlay.MaterialComponents.Dialog.Alert</item>
673+
<item name="android:alertDialogTheme">@style/ThemeOverlay.MaterialComponents.Dialog.Alert.Framework</item>
669674
<item name="materialAlertDialogTheme">@style/ThemeOverlay.MaterialComponents.MaterialAlertDialog</item>
670675

671676
<!-- Type styles -->
672677
<item name="textAppearanceLargePopupMenu">?attr/textAppearanceSubtitle1</item>
673678
<item name="textAppearanceSmallPopupMenu">?attr/textAppearanceSubtitle1</item>
674679
</style>
675680

676-
<style name="Base.V21.Theme.MaterialComponents.Dialog" parent="Base.V14.Theme.MaterialComponents.Dialog">
677-
<item name="android:alertDialogTheme">@style/ThemeOverlay.MaterialComponents.Dialog.Alert.Framework</item>
678-
</style>
679-
680-
<style name="Base.V14.Theme.MaterialComponents.Light.Dialog" parent="Base.V14.Theme.MaterialComponents.Light.Dialog.Bridge">
681+
<style name="Base.Theme.MaterialComponents.Light.Dialog" parent="Base.Theme.MaterialComponents.Light.Dialog.Bridge">
681682
<item name="viewInflaterClass">com.google.android.material.theme.MaterialComponentsViewInflater</item>
682683

683684
<!-- Colors -->
@@ -723,29 +724,14 @@
723724
<item name="toolbarStyle">@style/Widget.MaterialComponents.Toolbar</item>
724725

725726
<item name="alertDialogTheme">@style/ThemeOverlay.MaterialComponents.Dialog.Alert</item>
727+
<item name="android:alertDialogTheme">@style/ThemeOverlay.MaterialComponents.Light.Dialog.Alert.Framework</item>
726728
<item name="materialAlertDialogTheme">@style/ThemeOverlay.MaterialComponents.MaterialAlertDialog</item>
727729

728730
<!-- Type styles -->
729731
<item name="textAppearanceLargePopupMenu">?attr/textAppearanceSubtitle1</item>
730732
<item name="textAppearanceSmallPopupMenu">?attr/textAppearanceSubtitle1</item>
731733
</style>
732734

733-
<style name="Base.V21.Theme.MaterialComponents.Light.Dialog" parent="Base.V14.Theme.MaterialComponents.Light.Dialog">
734-
<item name="android:alertDialogTheme">@style/ThemeOverlay.MaterialComponents.Light.Dialog.Alert.Framework</item>
735-
</style>
736-
737-
<!-- Themes in the "Base.Theme" family vary based on the current platform
738-
version to provide the correct basis on each device. You probably don't
739-
want to use them directly in your apps.
740-
741-
Themes in the "Theme.MaterialComponents" family are meant to be extended or used
742-
directly by apps. -->
743-
<eat-comment/>
744-
745-
<style name="Base.Theme.MaterialComponents.Dialog" parent="Base.V21.Theme.MaterialComponents.Dialog"/>
746-
747-
<style name="Base.Theme.MaterialComponents.Light.Dialog" parent="Base.V21.Theme.MaterialComponents.Light.Dialog"/>
748-
749735
<style name="Base.Theme.MaterialComponents.Dialog.Alert">
750736
<item name="android:windowMinWidthMajor">@dimen/abc_dialog_min_width_major</item>
751737
<item name="android:windowMinWidthMinor">@dimen/abc_dialog_min_width_minor</item>

‎lib/java/com/google/android/material/dialog/res/values/themes_base_bridge.xml‎

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,15 @@
2727

2828
<style name="Platform.MaterialComponents.Light.Dialog" parent="Theme.AppCompat.Light.Dialog"/>
2929

30-
<!-- All new attributes should be set in the following four Base.V14 themes. -->
30+
<!-- Themes in the "Base.Theme" family vary based on the current platform
31+
version to provide the correct basis on each device. You probably don't
32+
want to use them directly in your apps.
33+
34+
Themes in the "Theme.MaterialComponents" family are meant to be extended or used
35+
directly by apps. -->
3136
<eat-comment/>
3237

33-
<style name="Base.V14.Theme.MaterialComponents.Dialog.Bridge" parent="Platform.MaterialComponents.Dialog">
38+
<style name="Base.Theme.MaterialComponents.Dialog.Bridge" parent="Platform.MaterialComponents.Dialog">
3439
<item name="isMaterialTheme">true</item>
3540

3641
<item name="colorPrimaryVariant">@color/design_dark_default_color_primary_variant</item>
@@ -113,7 +118,7 @@
113118
<item name="elevationOverlayColor">?attr/colorOnSurface</item>
114119
</style>
115120

116-
<style name="Base.V14.Theme.MaterialComponents.Light.Dialog.Bridge" parent="Platform.MaterialComponents.Light.Dialog">
121+
<style name="Base.Theme.MaterialComponents.Light.Dialog.Bridge" parent="Platform.MaterialComponents.Light.Dialog">
117122
<item name="isMaterialTheme">true</item>
118123

119124
<item name="colorPrimaryVariant">@color/design_default_color_primary_variant</item>
@@ -196,16 +201,4 @@
196201
<item name="elevationOverlayColor">?attr/colorOnSurface</item>
197202
</style>
198203

199-
<!-- Themes in the "Base.Theme" family vary based on the current platform
200-
version to provide the correct basis on each device. You probably don't
201-
want to use them directly in your apps.
202-
203-
Themes in the "Theme.MaterialComponents" family are meant to be extended or used
204-
directly by apps. -->
205-
<eat-comment/>
206-
207-
<style name="Base.Theme.MaterialComponents.Dialog.Bridge" parent="Base.V14.Theme.MaterialComponents.Dialog.Bridge"/>
208-
209-
<style name="Base.Theme.MaterialComponents.Light.Dialog.Bridge" parent="Base.V14.Theme.MaterialComponents.Light.Dialog.Bridge"/>
210-
211204
</resources>

‎lib/java/com/google/android/material/dialog/res/values/themes_overlay.xml‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,18 @@
1515
~ limitations under the License.
1616
-->
1717
<resources xmlns:tools="http://schemas.android.com/tools">
18-
<style name="Base.V14.ThemeOverlay.MaterialComponents.Dialog" parent="ThemeOverlay.AppCompat.Dialog">
18+
<style name="Base.ThemeOverlay.MaterialComponents.Dialog" parent="ThemeOverlay.AppCompat.Dialog">
19+
<item name="android:windowBackground">@drawable/mtrl_dialog_background</item>
1920
<!-- Widget styles -->
2021
<item name="materialButtonStyle">@style/Widget.MaterialComponents.Button.TextButton.Dialog.Flush</item>
2122
</style>
2223

23-
<style name="Base.V14.ThemeOverlay.MaterialComponents.Dialog.Alert" parent="ThemeOverlay.AppCompat.Dialog.Alert">
24+
<style name="Base.ThemeOverlay.MaterialComponents.Dialog.Alert" parent="ThemeOverlay.AppCompat.Dialog.Alert">
2425
<!-- Widget styles -->
2526
<item name="buttonBarButtonStyle">@style/Widget.MaterialComponents.Button.TextButton.Dialog.Flush</item>
2627
</style>
2728

28-
<style name="Base.V14.ThemeOverlay.MaterialComponents.MaterialAlertDialog" parent="ThemeOverlay.AppCompat.Dialog.Alert">
29+
<style name="Base.ThemeOverlay.MaterialComponents.MaterialAlertDialog" parent="ThemeOverlay.AppCompat.Dialog.Alert">
2930
<!-- Widget styles -->
3031
<item name="materialAlertDialogButtonSpacerVisibility">@integer/mtrl_view_invisible</item>
3132
<item name="alertDialogStyle">@style/MaterialAlertDialog.MaterialComponents</item>
@@ -39,13 +40,6 @@
3940
<item name="materialAlertDialogBodyTextStyle">@style/MaterialAlertDialog.MaterialComponents.Body.Text</item>
4041
</style>
4142

42-
<style name="Base.ThemeOverlay.MaterialComponents.Dialog" parent="Base.V14.ThemeOverlay.MaterialComponents.Dialog">
43-
<item name="android:windowBackground">@drawable/mtrl_dialog_background</item>
44-
</style>
45-
46-
<style name="Base.ThemeOverlay.MaterialComponents.Dialog.Alert" parent="Base.V14.ThemeOverlay.MaterialComponents.Dialog.Alert"/>
47-
<style name="Base.ThemeOverlay.MaterialComponents.MaterialAlertDialog" parent="Base.V14.ThemeOverlay.MaterialComponents.MaterialAlertDialog"/>
48-
4943
<!--
5044
MaterialComponents ThemeOverlays for Framework Alert Dialogs.
5145
-->

‎lib/java/com/google/android/material/sidesheet/res/values/themes_base.xml‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,33 +15,25 @@
1515
~ limitations under the License.
1616
-->
1717
<resources>
18-
<style name="Base.V14.Theme.Material3.Light.SideSheetDialog" parent="Theme.Material3.Light.Dialog">
18+
<style name="Base.Theme.Material3.Light.SideSheetDialog" parent="Theme.Material3.Light.Dialog">
1919
<item name="android:windowIsFloating">false</item>
2020
<item name="android:windowBackground">@android:color/transparent</item>
2121
<item name="android:windowAnimationStyle">@style/Animation.Material3.SideSheetDialog</item>
2222
<item name="sideSheetModalStyle">@style/Widget.Material3.SideSheet.Modal</item>
2323
</style>
2424

25-
<style name="Base.V14.Theme.Material3.Dark.SideSheetDialog" parent="Theme.Material3.Dark.Dialog">
25+
<style name="Base.Theme.Material3.Dark.SideSheetDialog" parent="Theme.Material3.Dark.Dialog">
2626
<item name="android:windowIsFloating">false</item>
2727
<item name="android:windowBackground">@android:color/transparent</item>
2828
<item name="android:windowAnimationStyle">@style/Animation.Material3.SideSheetDialog</item>
2929
<item name="sideSheetModalStyle">@style/Widget.Material3.SideSheet.Modal</item>
3030
</style>
3131

32-
<style name="Base.V14.ThemeOverlay.Material3.SideSheetDialog" parent="Base.ThemeOverlay.Material3.Dialog">
32+
<style name="Base.ThemeOverlay.Material3.SideSheetDialog" parent="Base.ThemeOverlay.Material3.Dialog">
33+
<item name="android:statusBarColor">@android:color/transparent</item>
3334
<item name="android:windowIsFloating">false</item>
3435
<item name="android:windowBackground">@android:color/transparent</item>
3536
<item name="android:windowAnimationStyle">@style/Animation.Material3.SideSheetDialog</item>
3637
<item name="sideSheetModalStyle">@style/Widget.Material3.SideSheet.Modal</item>
3738
</style>
38-
39-
<style name="Base.V21.ThemeOverlay.Material3.SideSheetDialog"
40-
parent="Base.V14.ThemeOverlay.Material3.SideSheetDialog">
41-
<item name="android:statusBarColor">@android:color/transparent</item>
42-
</style>
43-
44-
<style name="Base.Theme.Material3.Light.SideSheetDialog" parent="Base.V14.Theme.Material3.Light.SideSheetDialog"/>
45-
<style name="Base.Theme.Material3.Dark.SideSheetDialog" parent="Base.V14.Theme.Material3.Dark.SideSheetDialog"/>
46-
<style name="Base.ThemeOverlay.Material3.SideSheetDialog" parent="Base.V21.ThemeOverlay.Material3.SideSheetDialog"/>
4739
</resources>

‎lib/java/com/google/android/material/textfield/res/values/styles.xml‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@
203203
<item name="android:paddingBottom">13dp</item>
204204
</style>
205205

206-
<!-- Base styles for AutoCompleteTextView. You should use one of the sub-styles instead. -->
207-
<style name="Base.V14.Widget.MaterialComponents.AutoCompleteTextView" parent="Widget.AppCompat.AutoCompleteTextView">
206+
<!-- Base style for AutoCompleteTextView. You should use one of the sub-styles instead. -->
207+
<style name="Base.Widget.MaterialComponents.AutoCompleteTextView" parent="Widget.AppCompat.AutoCompleteTextView">
208208
<item name="enforceMaterialTheme">true</item>
209209
<item name="enforceTextAppearance">true</item>
210210
<item name="android:background">@null</item>
@@ -218,11 +218,8 @@
218218
<item name="android:paddingBottom">17dp</item>
219219
<item name="android:textAppearance">?attr/textAppearanceSubtitle1</item>
220220
<item name="android:dropDownVerticalOffset">@dimen/mtrl_exposed_dropdown_menu_popup_vertical_offset</item>
221-
<item name="android:popupElevation">@dimen/mtrl_exposed_dropdown_menu_popup_elevation</item>
222-
</style>
223-
224-
<style name="Base.Widget.MaterialComponents.AutoCompleteTextView" parent="Base.V14.Widget.MaterialComponents.AutoCompleteTextView">
225221
<item name="android:popupBackground">@null</item>
222+
<item name="android:popupElevation">@dimen/mtrl_exposed_dropdown_menu_popup_elevation</item>
226223
</style>
227224

228225
<!-- Styles for the AutocompleteTextView to be used if an ExposedDropdownMenu style is being used. -->

‎lib/java/com/google/android/material/theme/res/values-v24/themes_base.xml‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)