Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting normedmodtype.v #1339

Open
mkerjean opened this issue Oct 4, 2024 · 0 comments
Open

Splitting normedmodtype.v #1339

mkerjean opened this issue Oct 4, 2024 · 0 comments
Labels
renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Milestone

Comments

@mkerjean
Copy link
Collaborator

mkerjean commented Oct 4, 2024

Normedmodtype.v is a long file, and this triggers several issues, alike the one descripe in Issue#1167 advocating the spit of topology.v.

  • Compilation takes a long time, when trying to add a lemma.
  • The file mixes several new structures and adding an intermediate structure as in PR#1300 is complicated, maybe unecessary so.

As far as I can see, I see five parts in this file, not well ordered:

  • PseudoMetricNormedZmodules depending on numDomains
  • PseudoMetricNormedZmod depending on numFieldType
  • NormedModules depending on numDomains
  • NormModules depending on numFieldTypes
  • Theorems about realFied, in the last sections.

In particular, some lemmas about PseudoMetricNormedZmod depending on numFieldType (as add_continuous) are proved quite late, after the introduction of NormedModules.
I am not sure yet normedmodtype.v can be separated in 5 files, happy to discuss a better way to split it.

@affeldt-aist affeldt-aist added this to the 1.6.0 milestone Oct 8, 2024
@affeldt-aist affeldt-aist added the renaming/refactoring 🔧 This is about a renaming or refactoring in the library label Oct 8, 2024
@affeldt-aist affeldt-aist modified the milestones: 1.6.0, 1.7.0 Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renaming/refactoring 🔧 This is about a renaming or refactoring in the library
Projects
None yet
Development

No branches or pull requests

2 participants