implemented changes to move to deal.II version 9.6.0 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Mmm, before pushing I ran the indent script in the /scripts folder. So it is odd that now indent is all messed up. Do we need to change/update the indent script? |
luca-heltai
approved these changes
Nov 20, 2024
Contributor
|
Are you planning to make similar changes to make WaveBEM work with this new version of pi-BEM? |
Contributor
Author
|
Thanks a lot Luca, for the fix and the merge.
As of now, we have two different codes that are based on pi-BEM. One is
pi-BEM-free_surface (the new version of waveBEM,
https://www.sciencedirect.com/science/article/pii/S0307904X23002445), and
the other is wingbem (the solver for lifting surfaces such as hydrofoils,
https://arxiv.org/abs/2410.10529). Of course I am also updating both of
them to deal.II 9.6. If you want I can tell you more about both projects.
As for waveBEM itself, it is not using/linking to pi-BEM, and I am not
really developing/maintaining it any more. The new free surface model is
much better, and allows for steady simulations too. Plus, the new code is
fully parallel and works way better.
Andrea
…On Wed, Nov 20, 2024 at 12:04 PM Luca Heltai ***@***.***> wrote:
Are you planning to make similar changes to make WaveBEM work with this
new version of pi-BEM?
—
Reply to this email directly, view it on GitHub
<#55 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACDMNNFGTATFTBIMZWMQIUD2BRUFRAVCNFSM6AAAAABSBU4CFWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBYGI4DAOBVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
You should advertize this on the mailing list (there are many users wanting to use WaveBEM), or you should point the old WaveBEM to the new software. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also a test on 64-bit dof handler had to be changed. Both standard output and test source code had to be fixed