Skip to content

Commit 9995bf3

Browse files
committed
Merge pull request #1166 from mathjax/hotfix-2.5.2
Merge v2.5.2 for release
2 parents 574d4a3 + add4af8 commit 9995bf3

31 files changed

+201
-182
lines changed

CONTRIBUTING.md

+45-47
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
11
# Contributing to MathJax
22

3-
So you're interested in giving us a hand? That's awesome! We've put
4-
together some brief guidelines that should help you get started
5-
quickly and easily.
3+
You are interested in giving us a hand? That's awesome! We've put together some brief guidelines that should help you get started quickly and easily.
64

75
There are lots and lots of ways to get involved, this document covers:
86

9-
* [raising issues](#raising-issues)
7+
* [reporting an issue](#reporting-an-issue)
108
* [bug reports](#bug-reports)
119
* [feature requests](#feature-requests)
1210
* [change requests](#change-requests)
13-
* [working on MathJax core](#working-on-MathJax-core)
11+
* [working on MathJax core](#working-on-mathjax-core)
12+
* [key branches and tags](#key-branches--tags)
1413
* [submitting pull requests](#submitting-pull-requests)
15-
* [testing and quality assurance](#testing-and-quality-assurance)
16-
* [writing documentation](#writing-documentation)
17-
* [translation](#translation)
14+
* [testing and quality assurance](#testing-and-quality-assurance)
15+
* [writing documentation](#writing-documentation)
16+
* [translation](#translation)
1817
* [Conduct](#conduct)
1918

2019

@@ -33,7 +32,7 @@ requests](#submitting-pull-requests), but please respect the following restricti
3332
problem or requested your idea.
3433

3534
* Please **do not** use the issue tracker for personal support
36-
requests (use [the MathJax User Group](https://groups.google.com/forum/#!forum/mathjax-users).
35+
requests (use [the MathJax User Group](https://groups.google.com/forum/#!forum/mathjax-users)).
3736

3837
* Please **be civil**. Keep the discussion on topic and respect the
3938
opinions of others. See also our [Conduct Guidelines](#conduct)
@@ -48,21 +47,19 @@ Guidelines for bug reports:
4847
1. **Use the GitHub issue search** — check if the issue has already been
4948
reported.
5049

51-
2. **Check if the issue has been fixed** — try to reproduce it
52-
using the latest `develop` or look for [closed issues in the
53-
current milestone](https://github.com/MathJax/MathJax/issues?&page=1&state=closed).
50+
2. **Check if the issue has been fixed** — look for [closed issues in the
51+
current milestone](https://github.com/MathJax/MathJax/issues?&page=1&state=closed) or try to reproduce it
52+
using the latest `develop` branch. Please note that we only pack MathJax for releases, so on the `develop` branch you have to use `/unpacked/MathJax.js` etc. to test.
5453

55-
3. **Isolate the problem** — ideally create a [reduced test
56-
case](http://css-tricks.com/6263-reduced-test-cases/) and a live example.
54+
3. **Share a live sample of the problem** — without a live page it is usually impossible to debug problems; see also the Bug Report Template below.
5755

58-
4. **Include a screencast if relevant** - Is your issue about a design
59-
or front end feature or bug? The most helpful thing in the world is
60-
if we can *see* what you're talking about. Use
61-
[LICEcap](http://www.cockos.com/licecap/) to quickly and easily
62-
record a short screencast (24fps) and save it as an animated gif!
63-
Embed it directly into your GitHub issue. Kapow.
56+
4. **Isolate the problem** — a live sample is a starting point but if you want to speed things up create a [reduced test
57+
case](http://css-tricks.com/6263-reduced-test-cases/). Be specific about your setup (browser, OS versions etc). Use services like [jsbin](http://jsbin.com), [CodePen](http://codepen.io), [JSfiddle](http://jsfiddle.com) to make collaboration on minimal test cases easier for everyone. Use the unpacked copy of MathJax (`[...]/unpacked/MathJax.js` etc.) for better debugging.
6458

65-
5. Use the Bug Report template below or [click this
59+
5. **Include a screenshot/cast as a last resort** — Is your issue about a layout
60+
or design feature / bug but hard to reproduce or isolate? Then please provide a screenshot or screencast. Tools like [LICEcap](http://www.cockos.com/licecap/) or [SauceLabs](http://www.saucelabs.com) allow you to quickly and easily record a screencasts. Make it an animated gif, embed it directly into your GitHub issue -- kapow!
61+
62+
6. Use the Bug Report template below or [click this
6663
link](https://github.com/MathJax/MathJax/issues/new?title=Bug%3A&body=%23%23%23%20Issue%20Summary%0A%0A%23%23%23%20Steps%20to%20Reproduce%0A%0A1.%20This%20is%20the%20first%20step%0A%0AThis%20is%20a%20bug%20because...%0A%0A%23%23%23%20Technical%20details%0A%0A*%20MathJax%20Version%3A%20master%20-%20latest%20commit%3A%20%20INSERT%20COMMIT%20REF%0A*%20Client%20OS%3A%20%0A*%20Browser%3A%20%0A*%20)
6764
to start creating a bug report with the template automatically.
6865

@@ -132,12 +129,27 @@ a refactor, or an improvement to a feature, etc - please be sure to:
132129
are suggesting better than what's already there? Does it fit with
133130
the Roadmap?
134131

132+
## Working on MathJax core
133+
134+
You want to contribute code? Fantastic! Let's get you started.
135+
136+
### Key Branches & Tags
137+
138+
To get it out of the way:
139+
140+
- **[develop](https://github.com/MathJax/MathJax/tree/develop)** is
141+
the development branch. All work on the next release happens here so
142+
you should generally branch off `develop`. Do **NOT** use this branch
143+
for a production site.
144+
- **[master](https://github.com/MathJax/MathJax)** contains the latest
145+
release of MathJax. This branch may be used in production. Do
146+
**NOT** use this branch to work on MathJax's source.
135147

136148
### Submitting Pull Requests
137149

138150
Pull requests are awesome. If you're looking to raise a PR for
139151
something which doesn't have an open issue, please think carefully
140-
about [raising an issue](#raising-issues) which your PR can close,
152+
about [raising an issue](#reporting-an-issue) which your PR can close,
141153
especially if you're fixing a bug. This makes it more likely that
142154
there will be enough information available for your PR to be properly
143155
tested and merged.
@@ -165,7 +177,7 @@ Documentation [in our testing
165177
framework](https://github.com/MathJax/MathJax-testing).
166178

167179
Essentially though, [check out the latest develop
168-
branch](#contribute-to-core), take it for a spin, and if you find
180+
branch](#working-on-mathJax-core), take it for a spin, and if you find
169181
anything odd, please follow the [bug report guidelines](#bug-reports)
170182
and let us know!
171183

@@ -178,45 +190,31 @@ requests in the same way as branches:
178190
<https://gist.github.com/piscisaureus/3342247>.
179191

180192

181-
### Documentation
193+
### Writing documentation
182194

183195
MathJax's main documentation can be found at [docs.mathjax.org](http://docs.mathjax.org).
196+
The source of the docs is hosted in the
197+
[mathjax/mathjax-docs](http://github.com/mathjax/mathjax-docs) repo here on GitHub.
184198

185-
The documentation is generated using
186-
[Sphinx-doc](http://sphinx-doc.org/) and hosted on [Read the
187-
docs](http://readthedocs.org). The source of the docs is hosted in the
188-
[MathJax-Docs GitHub
189-
repository](http://github.com/mathjax/mathjax-docs).
190-
199+
The documentation is generated using [Sphinx-doc](http://sphinx-doc.org/) and hosted on
200+
[Read the docs](http://readthedocs.org).
191201
You can clone the repo and submit pull requests following the
192-
[pull-request](#pull-requests) guidelines.
202+
[pull-request](#submitting-pull-requests) guidelines.
193203

194204

195205
### Translation
196206

197207
If you wish to add or update translations of MathJax, please do it on
198208
[TranslateWiki.net](https://translatewiki.net/w/i.php?title=Special:Translate&group=out-mathjax-0-all)
199209
(and while you're there you can help other open source projects,
200-
too!).
210+
too, because you're awesome!).
201211

202212
For bug reports and other questions that don't fit on
203213
TranslateWiki.net, head over to the
204214
[mathjax/mathjax-i18n](https://github.com/mathjax/MathJax-i18n)
205215
repository.
206216

207-
208-
## Working on MathJax Core {core}
209-
210-
### Key Branches & Tags
211-
212-
- **[develop](https://github.com/MathJax/MathJax/tree/develop)** is
213-
the development branch. All work on the next release is here. Do
214-
**NOT** use this branch for a production site.
215-
- **[master](https://github.com/MathJax/MathJax)** contains the latest
216-
release of MathJax. This branch may be used in production.
217-
218-
219-
# Conduct
217+
## Conduct
220218

221219
We are committed to providing a friendly, safe and welcoming environment for
222220
all, regardless of gender, sexual orientation, disability, ethnicity, religion,
@@ -252,9 +250,9 @@ behaviour is not welcome.
252250
We also suggest to read [discourse's
253251
rules](http://blog.discourse.org/2013/03/the-universal-rules-of-civilized-discourse/)
254252

255-
### References
253+
## References
256254

257-
* We heavily borrowed from -- thanks to Mozilla and Ghost!
255+
* We heavily borrowed from Mozilla and Ghost -- thank you!
258256
* https://github.com/TryGhost/Ghost/blob/master/CONTRIBUTING.md
259257
* https://github.com/mozilla/rust/wiki/Note-development-policy
260258
* https://github.com/jden/CONTRIBUTING.md/blob/master/CONTRIBUTING.md

MathJax.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)