Skip to content

singleTabMode="fullwidth" does not update correctly with drag-n-drop #547

@vincent-lecrubier-skydio

Description

Problem
In singleTabMode="fullwidth" , the "fullWidth-ness" of individual tab groups is initially correct, but then is not maintained correctly during the lifecycle:

  • It updates correctly when a tab is removed by closing it (If one tab is remaining it becomes full width) 🟢
  • Does not update correctly when a tab is removed by dragging it somewhere else (If one tab is remaining it remains non-full width) 🔴
  • Does not update correctly when a tab is added by dragging from somewhere else (If there was only one tab is the group such that it was full-width, then after another is added, you now have 2 tabs that are sharing the full width) 🔴

To Reproduce
I'm out of free codesandboxes, but it's super simple to reproduce:

Steps to reproduce the behavior:

  1. Use default dockview demo
  2. Add singleTabMode="fullwidth" to <DockviewReact/>
  3. Move tabs around by drag n drop

Expected behavior
The "fullWidth-ness" of individual tab groups remains correct

Screenshots

Screen.Recording.2024-03-11.at.12.06.38.PM.mov

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions