minor code tweaks from self review

Author: diosmosis

classes/WpMatomo/Admin/TrackingSettings.php

@@ -82,8 +82,9 @@ public static function is_track_script_used_in_wp_config( $abspath_override = nu
 			return null;
 		}
 
+		// phpcs:disable WordPress.PHP.NoSilencedErrors.Discouraged
 		// phpcs:disable WordPress.WP.AlternativeFunctions.file_get_contents_file_get_contents
-		$wp_config_contents = file_get_contents( $wp_config_path );
+		$wp_config_contents = @file_get_contents( $wp_config_path );
 
 		// some systems may disable reading of files outside of wp-content
 		if ( ! is_string( $wp_config_contents ) ) {

classes/WpMatomo/TrackingCode/TrackingCodeGenerator.php

@@ -328,6 +328,7 @@ function ( $host ) {
 
 			// set cookie via javascript cookie for known AI bots so we can skip tracking server side
 			// for them.
+			// NOTE: this must be done ONLY for known AI bots to be compliant with privacy regulations.
 			$user_agent_substrings = wp_json_encode( AjaxTracker::AI_BOT_USER_AGENT_SUBSTRINGS );
 			array_unshift(
 				$options,

misc/track_ai_bot.php

@@ -25,17 +25,17 @@ function matomo_track_if_ai_bot() {
 	if (
 		( ! defined( 'WP_CACHE' ) || ! WP_CACHE )
 		&& empty( $_GET['mtm_esi'] )
-	) {
-		return; // advanced-cache.php not in use
+	) { // advanced-cache.php not in use and we are not tracking via esi:include
+		return;
 	}
 
-	if ( isset( $_GET['mtm_esi'] ) ) {
-		$GLOBALS['MATOMO_IN_AI_ESI'] = true; // executing via esi:include directive
+	if ( isset( $_GET['mtm_esi'] ) ) { // executing via esi:include directive
+		$GLOBALS['MATOMO_IN_AI_ESI'] = true;
 	}
 
 	require_once __DIR__ . '/../app/vendor/matomo/matomo-php-tracker/MatomoTracker.php';
 
-	// check user agent is AI bot first thing, so if it is a normal request, we do
+	// check user agent is AI bot first thing, so if it is a normal request we do
 	// as little extra work as possible
 	$user_agent = ! empty( $_SERVER['HTTP_USER_AGENT'] ) ? $_SERVER['HTTP_USER_AGENT'] : '';
 	if ( ! MatomoTracker::isUserAgentAIBot( $user_agent ) ) {