Fix UI feedback on failing star/unstar api calls

Author: tzi

plugins/SegmentEditor/API.php

@@ -376,6 +376,7 @@ public function star(int $idSegment): array
 
         return [
             'result' => $result,
+            'starred' => 1,
             'starred_by' => $login,
         ];
     }
@@ -400,6 +401,7 @@ public function unstar(int $idSegment): array
         $result = $this->getModel()->updateSegment($idSegment, $bind);
 
         return [
+            'starred' => 0,
             'result' => $result,
         ];
     }

plugins/SegmentEditor/javascripts/Segmentation.js

@@ -462,13 +462,16 @@ Segmentation = (function($) {
             "userLogin": piwik.userLogin,
             "idSegment": idSegment,
           }, 'POST');
-          ajaxHandler.setErrorCallback(function () {
-            segment.starred = !segment.starred;
-            updateStarredSegment(segment, true);
-          });
+          ajaxHandler.useCallbackInCaseOfError();
           ajaxHandler.setCallback(function (response) {
-            segment.starred_by = response.starred_by;
-            updateStarredSegment(segment);
+            if (!response || response.result == 'error') {
+              segment.starred = !segment.starred;
+              updateStarredSegment(segment, true);
+            } else {
+              segment.starred = !!response.starred;
+              segment.starred_by = response.starred_by;
+              updateStarredSegment(segment);
+            }
           });
           ajaxHandler.send();
         }