Update UI screenshots and fix tests

Author: tzi

plugins/CustomDimensions/tests/UI/expected-screenshots/CustomDimensions_report_visit_mainmenu.png

@@ -520,7 +520,9 @@ Segmentation = (function($) {
                 const comparisonService = window.CoreHome.ComparisonsStoreInstance;
                 const segmentDefinition = $button.closest('li').data('definition');
                 if ($button.attr('data-state') === 'active') {
-                  comparisonService.removeSegmentComparisonByDefinition(segmentDefinition);
+                  if (segmentDefinition) {
+                    comparisonService.removeSegmentComparisonByDefinition(segmentDefinition);
+                  }
                 } else {
                   comparisonService.addSegmentComparison({
                     segment: segmentDefinition,

plugins/SegmentEditor/javascripts/Segmentation.js

@@ -0,0 +1,20 @@
+/*!
+ * Matomo - free/libre analytics platform
+ *
+ * SegmentEditor screenshot tests.
+ *
+ * @link    https://matomo.org
+ * @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
+ */
+
+describe("SegmentManagementPageTest", function () {
+    var generalParams = 'idSite=1&period=range&date=2010-03-06,2010-03-08';
+    var url = '?module=CoreHome&action=index&' + generalParams + '#?' + generalParams + '&category=General_Visitors&subcategory=CoreHome_Segments';
+
+    it("should load correctly", async function() {
+        await page.goto(url);
+        await page.waitForNetworkIdle();
+
+        expect(await page.screenshot({ fullPage: true })).to.matchImage('initial');
+    });
+});

plugins/SegmentEditor/tests/UI/SegmentManagementPage_spec.js

@@ -28,7 +28,7 @@ describe('SegmentComparison', () => {
       maxSegments);
 
     // We check that the title attribute is still not the max limit message
-    let title = await page.$eval('.segmentationContainer .segmentList li:last-child', (el) => el.getAttribute('title'));
+    let title = await page.$eval('.segmentationContainer .segmentList li:last-child .compareSegment', (el) => el.getAttribute('title'));
     expect(title).to.not.equal(maxLimitMessage);
 
     await page.waitForSelector('.segmentationContainer');

plugins/SegmentEditor/tests/UI/SegmentSelectorCompare_spec.js

@@ -320,7 +320,7 @@ describe("SegmentSelectorEditorTest", function () {
         await page.goto(url);
 
         await page.click('.segmentationContainer .title');
-        await page.click('a.add_new_segment');
+        await page.click('button.add_new_segment');
         await page.type('input.edit_segment_name', 'complex segment');
 
         await page.waitForSelector('.segmentRow0');