Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pt-br translations #132

Closed
wants to merge 24 commits into from

Conversation

giovana-morais
Copy link

@giovana-morais giovana-morais commented May 6, 2023

Closes #131.

Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Please do not overwrite the existing english versions.

Overall, we have to come up with a scheme how to manage translations:

  • README: I think the best the pattern shown in https://github.com/tiimgreen/github-cheat-sheet: README.[lang].md files and a link Read this in other languages in the main README.
  • Content: Please make new files for the translated handouts as well.

An unresolved problem is keeping translations synchronous and up to date.

@giovana-morais
Copy link
Author

@timhoffm thanks for jumping in!
I overwrote the file because I thought it would stay only in this fork, but I like your idea much better. I'll create the new files for both README and the handouts.

regarding keeping the translations open to date, I thought about maybe automatically creating an issue for the translation repository whenever we have new PRs merged in the official one, via the CI tool. not sure if it's the best approach, but I think it will give us visibility. 🤔

@giovana-morais giovana-morais changed the title traduz dicas feat: add pt-br translations May 8, 2023
@timhoffm timhoffm dismissed their stale review May 15, 2023 19:54

Requested changes addressed.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thank you so much @giovana-morais !

README.pt-br.md Outdated Show resolved Hide resolved
README.pt-br.md Outdated Show resolved Hide resolved
README.pt-br.md Outdated Show resolved Hide resolved
README.pt-br.md Outdated Show resolved Hide resolved
handout-beginner.pt-br.tex Outdated Show resolved Hide resolved
handout-beginner.pt-br.tex Show resolved Hide resolved
handout-beginner.pt-br.tex Outdated Show resolved Hide resolved
handout-beginner.pt-br.tex Outdated Show resolved Hide resolved
handout-beginner.pt-br.tex Outdated Show resolved Hide resolved
handout-intermediate.pt-br.tex Outdated Show resolved Hide resolved
giovana-morais and others added 8 commits May 24, 2023 16:08
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
@giovana-morais
Copy link
Author

@timhoffm any suggestions on how to proceed with the Makefile? I thought about creating something like "make translation ", but I'm open to suggestions

@giovana-morais giovana-morais requested a review from melissawm July 13, 2023 19:59
Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great - some minor comments but I'm approving since the contents in general are done. Obrigada @giovana-morais !!

(EDIT: Can you mark it as ready for review?)

README.pt-br.md Outdated Show resolved Hide resolved
README.pt-br.md Outdated Show resolved Hide resolved
README.pt-br.md Outdated Show resolved Hide resolved
handout-beginner.pt-br.tex Outdated Show resolved Hide resolved
handout-intermediate.pt-br.tex Show resolved Hide resolved
@giovana-morais giovana-morais marked this pull request as ready for review July 19, 2023 14:49
giovana-morais and others added 3 commits July 19, 2023 11:54
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
@giovana-morais giovana-morais requested a review from timhoffm July 19, 2023 17:00
@giovana-morais
Copy link
Author

@timhoffm i was thinking that the specific Makefile for the translation handouts could be done in the PyLadies repo instead of here. can you review the PR as it is?

@timhoffm
Copy link
Member

I don't speak portugese and thus are not qualified to review the PR.

Copy link
Member

@melissawm melissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timhoffm as far as the text goes, I'm happy with it!

@giovana-morais
Copy link
Author

I'll close this PR because I already merged the changes on the PyLadies Brasil fork. It makes more sense to keep it separate, so we can change the Makefile to generate the translated document instead of the original one and we have more freedom to use the translated version of the README as the original.
@melissawm thank you for the help reviewing the translation and thanks @timhoffm for the guidance in the translation patterns! Later I can open a new PR with only an update on the README pointing to the PyLadies Brasil translation for Portuguese.

Obrigada!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brazilian Portuguese translation
4 participants