-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pt-br translations #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Please do not overwrite the existing english versions.
Overall, we have to come up with a scheme how to manage translations:
- README: I think the best the pattern shown in https://github.com/tiimgreen/github-cheat-sheet:
README.[lang].md
files and a link Read this in other languages in the main README. - Content: Please make new files for the translated handouts as well.
An unresolved problem is keeping translations synchronous and up to date.
@timhoffm thanks for jumping in! regarding keeping the translations open to date, I thought about maybe automatically creating an issue for the translation repository whenever we have new PRs merged in the official one, via the CI tool. not sure if it's the best approach, but I think it will give us visibility. 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thank you so much @giovana-morais !
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
@timhoffm any suggestions on how to proceed with the Makefile? I thought about creating something like "make translation ", but I'm open to suggestions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great - some minor comments but I'm approving since the contents in general are done. Obrigada @giovana-morais !!
(EDIT: Can you mark it as ready for review?)
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
Co-authored-by: Melissa Weber Mendonça <[email protected]>
@timhoffm i was thinking that the specific Makefile for the translation handouts could be done in the PyLadies repo instead of here. can you review the PR as it is? |
I don't speak portugese and thus are not qualified to review the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timhoffm as far as the text goes, I'm happy with it!
I'll close this PR because I already merged the changes on the PyLadies Brasil fork. It makes more sense to keep it separate, so we can change the Makefile to generate the translated document instead of the original one and we have more freedom to use the translated version of the README as the original. Obrigada! |
Closes #131.