-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dpi was being set to 72 irrespective of what was supplied #20
Conversation
I haven't checked locally, but at least CI doesn't seem to be agreeing with you... (you can run the tests locally with run-mpl-test-suite.py; if the fix is correct you should be able to remove the excluded tests from the hardcoded list in that file. |
I realized that whatever I have done in this PR is not correct for sure. I am going to spend some time on this over the weekend... looks like I will have to dig into mpl code to figure out all the magic you described
|
9a5c02c
to
ba7a4bc
Compare
a59fe35
to
5bf26c4
Compare
d20a010
to
9c0a9c6
Compare
96166f0
to
de98f71
Compare
d9a67c2
to
90bdca6
Compare
7aa2de7
to
842fb24
Compare
45bd634
to
163a369
Compare
8d18fbe
to
5618fa6
Compare
486eb87
to
d3b6f25
Compare
closes #19 (I think)
And (possibly) gets rid of "Invalid dpi manipulations in vector output." mentioned in https://github.com/matplotlib/mplcairo/blob/master/ISSUES.rst
My apologies in advance if I am trivializing the issue but this just feels like an inadvertent oversight.