Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate baseline hashes during tests to reduce flakiness #234

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Generate baseline hashes during tests to reduce flakiness #234

wants to merge 2 commits into from

Conversation

ConorMacBride
Copy link
Member

@ConorMacBride ConorMacBride commented Nov 6, 2024 •
edited
Loading

  • The pytest-mpl test suite relies on lots of hardcoded hashes remaining the same, which leads to lots of test failures on different platforms.
  • Instead of hardcoding the hashes we can quickly generate them during each test run and then modify specific hashes to simulate an expected test failure.

Closes #232
Closes #225
Closes #179

@ConorMacBride ConorMacBride added the infrastructure PRs related to the package and tests etc label Nov 6, 2024
@ConorMacBride ConorMacBride force-pushed the remove-hashes branch 3 times, most recently from 668b09c to ce61e89 Compare November 6, 2024 21:34
@ConorMacBride ConorMacBride marked this pull request as ready for review November 6, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astrofrog astrofrog Awaiting requested review from astrofrog

@Cadair Cadair Awaiting requested review from Cadair

Assignees
No one assigned
Labels
infrastructure PRs related to the package and tests etc
Projects
None yet
Milestone
No milestone
1 participant
@ConorMacBride