Skip to content

Commit 97a2f14

Browse files
committed
fix: fix ShowPartitions error, milvus-io#246
1 parent 0127694 commit 97a2f14

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

src/impl/MilvusClientImpl.cpp

+5-1
Original file line numberDiff line numberDiff line change
@@ -423,8 +423,12 @@ MilvusClientImpl::ShowPartitions(const std::string& collection_name, const std::
423423
partitions_info.reserve(count);
424424
}
425425
for (int i = 0; i < count; ++i) {
426+
int inmemory_percentage = 0;
427+
if (response.inmemory_percentages_size() > i) {
428+
inmemory_percentage = response.inmemory_percentages(i);
429+
}
426430
partitions_info.emplace_back(response.partition_names(i), response.partitionids(i),
427-
response.created_timestamps(i), response.inmemory_percentages(i));
431+
response.created_timestamps(i), inmemory_percentage);
428432
}
429433
};
430434

test/st/TestCollection.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ TEST_P(MilvusServerTestCollection, CreateAndDeleteCollection) {
5656
EXPECT_EQ(collection_infos.front().MemoryPercentage(), 0);
5757
EXPECT_EQ(collection_infos.front().Name(), "Foo");
5858

59+
// test for https://github.com/milvus-io/milvus-sdk-cpp/issues/246
60+
milvus::PartitionsInfo partitionsInfo{};
61+
status = client_->ShowPartitions("Foo", std::vector<std::string>{}, partitionsInfo);
62+
EXPECT_TRUE(status.IsOk());
63+
5964
names.emplace_back("Foo");
6065
collection_infos.clear();
6166
status = client_->LoadCollection("Foo");

0 commit comments

Comments
 (0)