Fixing code (Sensiolabs)

Author: Mauro Cassani

composer.lock

@@ -12,10 +12,10 @@
 
 use InMemoryList\Application\Exceptions\MalformedParametersException;
 use InMemoryList\Application\Exceptions\NotSupportedDriverException;
-use InMemoryList\Domain\Model\Contracts\ListRepository;
+use InMemoryList\Domain\Model\Contracts\ListRepositoryInterface;
 use InMemoryList\Domain\Model\ListElement;
 use InMemoryList\Domain\Model\ListElementUuid;
-use InMemoryList\Infrastructure\Domain\Model\ListCollectionFactory;
+use InMemoryList\Infrastructure\Domain\Model\ListCollectionFactoryInterface;
 
 class Client
 {
@@ -25,7 +25,7 @@ class Client
     private $driver;
 
     /**
-     * @var ListRepository
+     * @var ListRepositoryInterface
      */
     private $repository;
 
@@ -83,7 +83,7 @@ private function _setRepository($driver, array $config = [])
     }
 
     /**
-     * @return ListRepository
+     * @return ListRepositoryInterface
      */
     public function getRepository()
     {
@@ -102,7 +102,7 @@ public function create(array $elements, array $parameters = [])
     {
         try {
             $this->_validateParameters($parameters);
-            $factory = new ListCollectionFactory();
+            $factory = new ListCollectionFactoryInterface();
             $list = $factory->create(
                 $elements,
                 (isset($parameters['headers'])) ? $parameters['headers'] : [],

src/InMemoryList/Application/Client.php

@@ -12,7 +12,7 @@
 
 use InMemoryList\Domain\Model\ListCollection;
 
-interface ListFactory
+interface ListFactoryInterface
 {
     /**
      * @param array $elements

src/InMemoryList/Domain/Model/Contracts/ListFactory.php src/InMemoryList/Domain/Model/Contracts/ListFactoryInterface.php

@@ -13,7 +13,7 @@
 use InMemoryList\Domain\Model\ListCollection;
 use InMemoryList\Domain\Model\ListElement;
 
-interface ListRepository
+interface ListRepositoryInterface
 {
     const CHUNK = 'chunk';
     const CHUNKSIZE = 1000;

src/InMemoryList/Domain/Model/Contracts/ListRepository.php src/InMemoryList/Domain/Model/Contracts/ListRepositoryInterface.php

@@ -10,7 +10,7 @@
 
 namespace InMemoryList\Domain\Model;
 
-use InMemoryList\Domain\Model\Contracts\ListRepository;
+use InMemoryList\Domain\Model\Contracts\ListRepositoryInterface;
 use InMemoryList\Domain\Model\Exceptions\ListCollectionNotAllowedUuidException;
 use Ramsey\Uuid\Uuid;
 
@@ -39,11 +39,11 @@ public function __construct($uuid = null)
     public function _setUuid($uuid = null)
     {
         $notAllowedNames = [
-            ListRepository::CHUNK,
-            ListRepository::HEADERS,
-            ListRepository::INDEX,
-            ListRepository::SEPARATOR,
-            ListRepository::STATISTICS,
+            ListRepositoryInterface::CHUNK,
+            ListRepositoryInterface::HEADERS,
+            ListRepositoryInterface::INDEX,
+            ListRepositoryInterface::SEPARATOR,
+            ListRepositoryInterface::STATISTICS,
         ];
 
         foreach ($notAllowedNames as $notAllowedName) {

src/InMemoryList/Domain/Model/ListCollectionUuid.php

@@ -10,7 +10,7 @@
 
 namespace InMemoryList\Domain\Model;
 
-use InMemoryList\Domain\Model\Contracts\ListRepository;
+use InMemoryList\Domain\Model\Contracts\ListRepositoryInterface;
 use InMemoryList\Domain\Model\Exceptions\ListElementNotAllowedUuidException;
 use Ramsey\Uuid\Uuid;
 
@@ -39,11 +39,11 @@ public function __construct($uuid = null)
     public function _setUUid($uuid = null)
     {
         $notAllowedNames = [
-            ListRepository::CHUNK,
-            ListRepository::HEADERS,
-            ListRepository::INDEX,
-            ListRepository::SEPARATOR,
-            ListRepository::STATISTICS,
+            ListRepositoryInterface::CHUNK,
+            ListRepositoryInterface::HEADERS,
+            ListRepositoryInterface::INDEX,
+            ListRepositoryInterface::SEPARATOR,
+            ListRepositoryInterface::STATISTICS,
         ];
 
         foreach ($notAllowedNames as $notAllowedName) {

src/InMemoryList/Domain/Model/ListElementUuid.php

@@ -14,11 +14,11 @@
 use InMemoryList\Domain\Model\ListCollection;
 use InMemoryList\Domain\Model\ListCollectionUuid;
 use InMemoryList\Domain\Model\ListElementUuid;
-use InMemoryList\Domain\Model\Contracts\ListFactory as Factory;
+use InMemoryList\Domain\Model\Contracts\ListFactoryInterface as Factory;
 use InMemoryList\Infrastructure\Domain\Model\Exceptions\CreateListFromEmptyArrayException;
 use InMemoryList\Infrastructure\Domain\Model\Exceptions\NotValidKeyElementInListException;
 
-class ListCollectionFactory implements Factory
+class ListCollectionFactoryInterface implements Factory
 {
     /**
      * @param array $elements

src/InMemoryList/Infrastructure/Domain/Model/ListCollectionFactory.php src/InMemoryList/Infrastructure/Domain/Model/ListCollectionFactoryInterface.php

@@ -14,12 +14,12 @@
 use InMemoryList\Domain\Model\Exceptions\ListElementNotConsistentException;
 use InMemoryList\Domain\Model\ListElement;
 use InMemoryList\Domain\Model\ListCollection;
-use InMemoryList\Domain\Model\Contracts\ListRepository;
+use InMemoryList\Domain\Model\Contracts\ListRepositoryInterface;
 use InMemoryList\Domain\Model\ListElementUuid;
 use InMemoryList\Infrastructure\Persistance\Exceptions\ListAlreadyExistsException;
 use InMemoryList\Infrastructure\Persistance\Exceptions\ListDoesNotExistsException;
 
-class ApcuRepository extends AbstractRepository implements ListRepository
+class ApcuRepositoryInterface extends AbstractRepository implements ListRepositoryInterface
 {
     /**
      * @param ListCollection $list
@@ -172,7 +172,7 @@ public function getHeaders($listUuid)
      */
     public function getIndex($listUuid = null, $flush = null)
     {
-        $indexKey = ListRepository::INDEX;
+        $indexKey = ListRepositoryInterface::INDEX;
         $index = apcu_fetch($indexKey);
 
         if ($flush && $index) {
@@ -199,7 +199,7 @@ public function getIndex($listUuid = null, $flush = null)
      */
     private function _addOrUpdateListToIndex($listUuid, $size, $numberOfChunks, $chunkSize, $ttl = null)
     {
-        $indexKey = ListRepository::INDEX;
+        $indexKey = ListRepositoryInterface::INDEX;
         $indexArray = serialize([
             'uuid' => $listUuid,
             'created_on' => new \DateTimeImmutable(),
@@ -288,7 +288,7 @@ public function pushElement($listUuid, ListElement $listElement)
      */
     public function removeListFromIndex($listUuid)
     {
-        $indexKey = ListRepository::INDEX;
+        $indexKey = ListRepositoryInterface::INDEX;
         $index = $this->getIndex();
         unset($index[(string) $listUuid]);