Removed unused Plugin ctor

Author: ugol-1

mavros/include/mavros/plugin.hpp

@@ -74,10 +74,8 @@ class Plugin : public std::enable_shared_from_this<Plugin>
   //! Subscriptions vector
   using Subscriptions = std::vector<HandlerInfo>;
 
-  explicit Plugin(UASPtr uas);
-
   explicit Plugin(
-    UASPtr uas, const std::string & subnode,
+    UASPtr uas, const std::string & subnode_name,
     const rclcpp::NodeOptions & options = rclcpp::NodeOptions());
 
   virtual ~Plugin() = default;

mavros/src/lib/plugin.cpp

@@ -18,10 +18,6 @@
 
 using mavros::plugin::Plugin;
 
-Plugin::Plugin(UASPtr uas)
-: uas_(uas), node(uas_)
-{}
-
 Plugin::Plugin(
   UASPtr uas, const std::string & subnode_name,
   const rclcpp::NodeOptions & options)

mavros/test/test_uas.cpp

@@ -62,7 +62,7 @@ class MockPlugin : public plugin::Plugin
   using SharedPtr = std::shared_ptr<MockPlugin>;
 
   explicit MockPlugin(UAS::SharedPtr uas_)
-  : Plugin(uas_) {}
+  : Plugin(uas_, "mock_plugin") {}
 
   MOCK_METHOD0(get_subscriptions, plugin::Plugin::Subscriptions(void));