Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't support signing? #82

Open
hamishwillee opened this issue Jan 27, 2021 · 3 comments
Open

Don't support signing? #82

hamishwillee opened this issue Jan 27, 2021 · 3 comments

Comments

@hamishwillee
Copy link

hamishwillee commented Jan 27, 2021

Just confirming for the mavlink docs tat this library doesn't support signing - right?

Are there any more docs than provided on the readme?
For context, I'm trying to characterize the things provided by each project

  • ie level of docs (where this one for C might be full
  • level of testing - ie what is tested, unit test, round trip tests, test that send receive from C library etc.
@patrickelectric
Copy link
Member

patrickelectric commented Jan 28, 2021

Hi @hamishwillee, I hope that you are doing fine.

About rust-mavlink, it indeed has a support for signed messages, but not fully.
It can receive but will do nothing with the signed value itself.

For documentation, you can get it here: https://docs.rs/mavlink/latest/mavlink/
For testing: https://github.com/mavlink/rust-mavlink/tree/master/tests

  • They are done with some hardcoded messages to check if the pack/unpack values are correct and a self test of the internal functions.

@hamishwillee
Copy link
Author

Thank you very much for the clarification.

@hamishwillee
Copy link
Author

Note, I've updated mavlink docs with link in mavlink/mavlink-devguide#312

I have not updated the information on signing because it still isn't quite clear to me what you mean by not supported. Full signing support would look something like:

  1. Has a mechanism for setting a key to use for signing messages (key management itself might be in hardware).
  2. Has mechanism for turning signing on and off
  3. If signing turned on will sign MAVLink 2 messages.
  4. If signing not turned on will parse signed and unsigned messages
  5. If signing turned on will reject unsigned messages by default, but has hooks to allow an implementation to choose to keep some messages.

Assuming we're aligned on the above can you confirm again which it does/does not do?

@hamishwillee hamishwillee reopened this Feb 2, 2021
@pv42 pv42 mentioned this issue Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants