-
Notifications
You must be signed in to change notification settings - Fork 48
Open
Labels
featureNew functionality, or change in existing functionalityNew functionality, or change in existing functionalityinfrastructureHas to do with changes to the development process, e.g., build scripts, CI, testing utilitiesHas to do with changes to the development process, e.g., build scripts, CI, testing utilities
Description
The problem
Currently, our linter is not reproducible. Some linters are not version controlled at all, which causes CI to break over time. But even for ones that are pinned in CI, the version used locally may be different.
Possible solution
To make linting reproducible, we can replace our custom lint.sh
script with a tool like Trunk Code Quality.
Alternative solutions
We could try to make reproducible linting ourselves using, e.g., Docker or Bazel, but, given that Trunk is free for open source projects and is really well designed, there isn't really any reason not to use it.
Metadata
Metadata
Assignees
Labels
featureNew functionality, or change in existing functionalityNew functionality, or change in existing functionalityinfrastructureHas to do with changes to the development process, e.g., build scripts, CI, testing utilitiesHas to do with changes to the development process, e.g., build scripts, CI, testing utilities