Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: duplicate transaction detection for CSV imports #1214

Open
mgirouard opened this issue Sep 29, 2024 · 6 comments
Open

Feature: duplicate transaction detection for CSV imports #1214

mgirouard opened this issue Sep 29, 2024 · 6 comments
Labels
💡 Feature Request New ideas for Maybe

Comments

@mgirouard
Copy link

Describe the bug
After a few weeks of using Maybe, I noticed that I find myself deleting duplicate transactions often. I regularly export CSVs from my banks and import them. It's easier for me to grab the last 30 days of activity and import them without having to grab specific dates, but when I do this I always wind up with duplicates.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any account
  2. Click on the ellipsis (...) menu and select Import transactions
  3. Follow the normal import flow (adjust fields, adjust data, confirm transactions)
  4. Navigate back to the account and review the latest transactions

(Perhaps a quicker repro would be to create a temporary account and import transactions twice)

Expected behavior
Duplicate transactions should be filtered out and not be imported.

Screenshots / Recordings
n/a

Additional context
Perhaps this could be done by hashing the transaction data -- exact matches would be a high probability of being duplicates (same description, same amount, same date, etc).

There will almost certainly be edge cases though -- eg: if I intentionally make the same purchase twice. One of the screens during import might be a good place to call this out and give me a checkbox to import it in or not.

@mgirouard mgirouard added the 🐛 Bug Something isn't working label Sep 29, 2024
@NGUYENDUCCHUNG21
Copy link

This text is italicized

@zachgoll
Copy link
Collaborator

@mgirouard currently, we do not have any support for detecting duplicates, but I agree that the feature would be useful.

I agree with you that hashing the raw transaction data is probably the best option for detecting matches.

What I'm not 100% sure about is the UI/UX for this (cc @justinfar)

My guess is that we could provide some sort of duplicate filtering / removal in our "clean" step?

CleanShot 2024-09-30 at 10 17 35@2x

@mgirouard
Copy link
Author

@zachgoll Yeah, this makes the most sense to me. Thanks for considering :)

@NGUYENDUCCHUNG21

This comment was marked as spam.

@zachgoll zachgoll added 💡 Feature Request New ideas for Maybe and removed 🐛 Bug Something isn't working labels Oct 7, 2024
@zachgoll zachgoll changed the title Bug: Duplicate transactions when importing from CSV Duplicate transaction detection for CSV imports Oct 7, 2024
@zachgoll zachgoll changed the title Duplicate transaction detection for CSV imports Feature: duplicate transaction detection for CSV imports Oct 7, 2024
@vanhalt
Copy link

vanhalt commented Oct 22, 2024

I was thinking about this. But by hashing the transaction we may be discarding duplicated charges:

10/07/2024,Apple Store,-36
10/07/2024,Apple Store,-36

@zachgoll
Copy link
Collaborator

@vanhalt yeah, that's why I'm thinking we'll need a UI/UX that simply surfaces duplicates to the user and then lets them decide whether to remove them or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 Feature Request New ideas for Maybe
Projects
None yet
Development

No branches or pull requests

4 participants