Skip to content

Commit 760a8a1

Browse files
committed
fix: opening cached windows
Replace 'undo' icon with 'window'. Rename the option from 'Reopen' to 'Open'. Denormalize url placeholders into original urls. Remove http scheme prefix from titles.
1 parent 8b345c1 commit 760a8a1

File tree

5 files changed

+16
-18
lines changed

5 files changed

+16
-18
lines changed

build/copy.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ const COPY = {
1919
'./src/assets/group-page-favicon.svg': `${ADDON_PATH}/assets/`,
2020
'./src/assets/snapshot-native.svg': `${ADDON_PATH}/assets/`,
2121
'./src/assets/proxy-native.svg': `${ADDON_PATH}/assets/`,
22-
'./src/assets/undo-native.svg': `${ADDON_PATH}/assets/`,
2322
'./src/assets/window-native.svg': `${ADDON_PATH}/assets/`,
2423
'./src/assets/private-window-native.svg': `${ADDON_PATH}/assets/`,
2524
[`./node_modules/vue/dist/${VUE_DIST}`]: `${ADDON_PATH}/vendor/`,

src/_locales/dict.common.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,16 +1078,16 @@ export const commonTranslations: Translations = {
10781078
},
10791079
'menu.browserAction.reopen_cached_win_first': {
10801080
en: tabsCount => {
1081-
if (tabsCount === 1) return `Reopen cached window (${tabsCount} tab)`
1082-
return `Reopen cached window (${tabsCount} tabs)`
1081+
if (tabsCount === 1) return `Open cached window (${tabsCount} tab)`
1082+
return `Open cached window (${tabsCount} tabs)`
10831083
},
1084-
zh_CN: tabsCount => `重开已缓存窗口${tabsCount} 个标签页)`,
1085-
zh_TW: tabsCount => `重開已快取視窗${tabsCount} 個分頁)`,
1084+
zh_CN: tabsCount => `打开缓存窗口${tabsCount} 个标签页)`,
1085+
zh_TW: tabsCount => `開啟快取視窗${tabsCount} 個分頁)`,
10861086
},
10871087
'menu.browserAction.reopen_cached_wins': {
1088-
en: 'Reopen cached window',
1089-
zh_CN: '重开已缓存窗口',
1090-
zh_TW: '重開已快取視窗',
1088+
en: 'Open cached window',
1089+
zh_CN: '打开缓存窗口',
1090+
zh_TW: '開啟快取視窗',
10911091
},
10921092
'menu.browserAction.reopen_cached_win': {
10931093
en: (tabsCount, panelsCount) => {

src/assets/undo-native.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/services/menu.actions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export async function importCtxMenu(ctxMenu: MenuConfs) {
9494

9595
export function createBrowserActionMenu() {
9696
createSettingsMenu()
97-
TabsBg.createReopenFromCacheMenu()
97+
TabsBg.createOpenFromCacheMenu()
9898
}
9999

100100
export function createSettingsMenu(): void {

src/services/tabs.bg.actions.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export async function reinitTabs(msg: string) {
8383
await loadTabs()
8484
}
8585

86-
export function createReopenFromCacheMenu() {
86+
export function createOpenFromCacheMenu() {
8787
// No cache
8888
if (!_tabsDataCache) return
8989

@@ -95,8 +95,8 @@ export function createReopenFromCacheMenu() {
9595
browser.menus.create({
9696
id: 'reopen_cached_win',
9797
title: translate('menu.browserAction.reopen_cached_win_first', winCache.length),
98-
icons: { '16': 'assets/undo-native.svg' },
99-
onclick: () => reopenCachedWindow(winCache),
98+
icons: { '16': 'assets/window-native.svg' },
99+
onclick: () => openCachedWindow(winCache),
100100
contexts: ['browser_action'],
101101
})
102102
}
@@ -106,7 +106,7 @@ export function createReopenFromCacheMenu() {
106106
const parentId = browser.menus.create({
107107
id: 'reopen_cached_wins',
108108
title: translate('menu.browserAction.reopen_cached_wins'),
109-
icons: { '16': 'assets/undo-native.svg' },
109+
icons: { '16': 'assets/window-native.svg' },
110110
contexts: ['browser_action'],
111111
})
112112

@@ -127,21 +127,21 @@ export function createReopenFromCacheMenu() {
127127
parentId,
128128
title: translate('menu.browserAction.reopen_cached_win', winCache.length, panelIds.size),
129129
icons: { '16': icon },
130-
onclick: () => reopenCachedWindow(winCache),
130+
onclick: () => openCachedWindow(winCache),
131131
contexts: ['browser_action'],
132132
})
133133
}
134134
}
135135
}
136136

137-
function reopenCachedWindow(cache: TabCache[]) {
137+
function openCachedWindow(cache: TabCache[]) {
138138
const incognito = !!cache[0]?.privWin
139139
const items: ItemInfo[] = []
140140
for (const cachedTab of cache) {
141141
items.push({
142142
id: cachedTab.id,
143-
url: cachedTab.url,
144-
title: cachedTab.customTitle ?? cachedTab.url,
143+
url: Utils.denormalizeUrl(cachedTab.url),
144+
title: cachedTab.customTitle ?? cachedTab.url.replace(/^https?:\/\//, ''),
145145
parentId: cachedTab.parentId ?? NOID,
146146
panelId: cachedTab.panelId ?? NOID,
147147
pinned: !!cachedTab.pin,

0 commit comments

Comments
 (0)