Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destructors are not run when calling exit #2

Open
paulthomson opened this issue Sep 29, 2017 · 1 comment
Open

Destructors are not run when calling exit #2

paulthomson opened this issue Sep 29, 2017 · 1 comment

Comments

@paulthomson
Copy link
Contributor

We should probably avoid calling exit and instead throw an exception, catch it in main and then exit. This allows destructors to execute. This may be important because helpful error messages may be hidden by unhelpful error messages about "leaking" objects. See mc-imperial/get-image-egl@063eb3b

We should also include the above commit!

@hevrard
Copy link
Collaborator

hevrard commented Sep 29, 2017

Sounds good!
It may be a bit more subtle here as the EGL / GLFW contexts are as isolated as possible in their own module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants