Skip to content

Lack of user control of Table->quiet in read_table-lib #2078

Open
@willend

Description

@willend

As @g5t has rightfully pointed out, the interface and control of the quiet flag of a Table from read_table-lib is in practice non-existent.

Also, in many use-cases of the that lib, the value can end up being undefined, which has lead to an edit like this one:

/*TK: Valgrind flags it as usage of uninitialised variable: */
Table->quiet = 0;

I would therefore suggest we consider trying to encourage / enforce use of Table_init (with a modified footprint including a char quiet) "always", but as multiple other functions in read_table lib also call Table_init, these would need a similar handle...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions