Skip to content

Commit 8c769bc

Browse files
mcj-coderclaude
andauthored
fix(skills): add missing required sections to 28 non-compliant skills (#391)
Added missing sections per SKILL-FORMAT.md requirements: - 4 skills: Added "When to Use" section - 8 skills: Added "Core Workflow" section - 15 skills: Added both "When to Use" and "Core Workflow" sections - 1 skill: Added "Overview", "When to Use", and "Core Workflow" sections All 55 skills now pass `npm run validate:skills`. Refs: #390 Co-authored-by: Claude Opus 4.5 <[email protected]>
1 parent 44e4bd6 commit 8c769bc

File tree

28 files changed

+385
-27
lines changed

28 files changed

+385
-27
lines changed

skills/agent-workitem-automation/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,25 @@ all times. If you cannot prove context or tooling, stop and fix that first.
2020
If an issue-driven workflow is required (work item comments, approvals, evidence tracking),
2121
use `issue-driven-delivery`.
2222

23+
## When to Use
24+
25+
- Agent is asked to autonomously manage a work item (GitHub, Azure DevOps, or Jira)
26+
- Comment mentions the agent with a task verb (e.g., "manage", "handle", "take", "own")
27+
- Need to resolve task board source, platform CLI, or step updates
28+
- Automating delivery flow across ticketing systems
29+
- Setting up CI/CD workflows triggered by ticket events
30+
31+
## Core Workflow
32+
33+
1. **Discovery**: Read README.md, locate Work Items section, infer platform from URL
34+
2. **Setup**: Verify CLI is installed and authenticated for the platform
35+
3. **Load ticket**: Fetch issue details, comments, acceptance criteria, and related PRs
36+
4. **Execute step**: Determine and execute only the next required step
37+
5. **Post update**: Comment with Summary, Evidence, Next Step, and Hand-off status
38+
6. **Update checklist**: Mark completed items in the issue body
39+
7. **Verify completion**: Use verification-before-completion for all acceptance criteria
40+
8. **Close or hand-off**: Close when complete with evidence, or hand off to human if blocked
41+
2342
## End-to-End Autonomous Delivery Flow
2443

2544
Autonomous delivery follows four explicit phases:

skills/agents-onboarding/SKILL.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,14 @@ must understand how to work in the repository by reading only AGENTS.md.
1818
**REQUIRED SUB-SKILL:** `superpowers:brainstorming`
1919
**REQUIRED SUB-SKILL:** `superpowers:verification-before-completion`
2020

21+
## When to Use
22+
23+
- User integrates AI agents into repository for first time
24+
- User asks to set up agent guidance, rules, or onboarding documentation
25+
- Repository is missing agent-specific onboarding docs (no AGENTS.md)
26+
- Fresh agent context needs to understand repository standards without conversation history
27+
- Existing AGENTS.md is incomplete or outdated and needs enhancement
28+
2129
## Core Workflow
2230

2331
1. **Announce** skill and why it applies.

skills/broken-window/SKILL.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,16 @@ objective and measurable—there is no "spirit vs letter" escape.
2424
- Standards violations detected during code review
2525
- Skills-first repos: Before starting work (validate prerequisites)
2626

27+
## Core Workflow
28+
29+
1. Detect warning, error, or standards violation
30+
2. Investigate root cause and document finding
31+
3. Estimate fix time and remaining work time
32+
4. Apply 2x rule: if fix time < 2x remaining work, fix immediately
33+
5. If fix time >= 2x remaining work, create tech-debt issue with steps to replicate
34+
6. Verify warning/error is resolved or issue is created
35+
7. Continue with original task
36+
2737
## The 2x Rule
2838

2939
```dot

skills/component-boundary-ownership/SKILL.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,15 @@ components) to scoped-colocation.
1717

1818
**REQUIRED:** superpowers:brainstorming, superpowers:verification-before-completion
1919

20+
## When to Use
21+
22+
- User decides repository organization or restructures codebase
23+
- User asks where functionality should live (component placement decisions)
24+
- User reviews or questions existing component boundaries
25+
- New functionality spans multiple existing components
26+
- Team ownership changes require boundary realignment
27+
- Deployment independence needs evaluation for splitting/merging components
28+
2029
## Core Workflow
2130

2231
1. **Identify candidate boundaries** based on deployment independence, team ownership, coupling analysis, and reuse patterns

skills/csharp-best-practices/SKILL.md

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,25 @@ detects the language/runtime configuration, prefers the newest supported feature
1616
consults version-specific references progressively from C# 10 upward while respecting
1717
repository conventions.
1818

19+
## When to Use
20+
21+
- Implementing or refactoring C# code in any .NET project
22+
- Reviewing C# code for best practice alignment
23+
- Upgrading code to use newer C# language features
24+
- Resolving analyzer warnings or style issues
25+
- Onboarding to an existing C# codebase to understand effective patterns
26+
27+
## Core Workflow
28+
29+
1. **Detect language version**: Check LangVersion in csproj, Directory.Build.props, or infer from TFM
30+
2. **Record determination**: Document effective C# version and how it was determined
31+
3. **Load references progressively**: Load reference docs from C# 10 up to the effective version
32+
4. **Apply highest-priority guidance**: When conflicts exist, newest version guidance wins
33+
5. **Handle optional analyzers**: Pause and request clarification for optional/contentious rules
34+
6. **Apply to touched code only**: Avoid unrelated formatting changes unless broader refactor requested
35+
7. **Validate build and tests**: Ensure changes compile and pass tests
36+
8. **Emit summary**: Document applied practices and any pending analyzer decisions
37+
1938
## Intent
2039

2140
Apply C# best practices appropriate to the project's **effective language version**.

skills/dotnet-bespoke-code-minimisation/SKILL.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,26 @@ Bias against bespoke internal implementations by preferring mature open-source t
99
composable libraries. When custom code is unavoidable, enforce justification rubrics that
1010
require explicit rationale, ownership, versioning, testing, and security considerations.
1111

12-
## Core
12+
## When to Use
13+
14+
- Proposals to write internal mappers, code generators, custom build scripts, or DI containers
15+
- Reviews where new internal tooling or bespoke framework layers are introduced
16+
- Evaluating whether to build vs buy/adopt for any infrastructure component
17+
- Reviewing PRs that add custom implementations for common concerns (validation, retries, caching)
18+
- Architectural decisions involving custom scaffolding or automation scripts
1319

14-
### When to use
20+
## Core Workflow
1521

16-
- Proposals to write internal mappers, code generators, custom build scripts, custom DI containers,
17-
or bespoke framework layers.
18-
- Reviews where new internal tooling is introduced.
22+
1. **Identify the concern**: Determine what functionality is being proposed (mapping, validation, CLI, etc.)
23+
2. **Search for OSS alternatives**: Evaluate mature open-source libraries that solve the same problem
24+
3. **Compare trade-offs**: Assess maintenance burden, test effort, performance, and community support
25+
4. **Apply decision framework**: Choose OSS unless clear justification exists for bespoke code
26+
5. **Require justification rubric**: If bespoke code is proposed, demand explicit rationale,
27+
ownership, versioning, tests, and security considerations
28+
6. **Document decision**: Record OSS evaluation, selection rationale, and maintenance plan
29+
7. **Verify in PR**: Check that PR includes evidence of OSS evaluation and rubric satisfaction
30+
31+
## Core
1932

2033
### Defaults
2134

skills/dotnet-best-practices/SKILL.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,16 @@ Use this skill when you are:
5050

5151
For cross-language or organization-wide security processes, use the `security-processes` skill alongside this one.
5252

53+
## Core Workflow
54+
55+
1. Identify target .NET version and load corresponding version reference
56+
2. For upgrades, load upgrade-cumulative.md and lts-upgrade-playbook.md
57+
3. Apply baseline engineering standards (security, reliability, performance, maintainability)
58+
4. Review code against version-specific recommended patterns
59+
5. Validate configuration centralisation and analyzer enforcement
60+
6. Produce target framework recommendation and adoption checklist
61+
7. Document risks, breaking changes, and required test gates
62+
5363
## Progressive loading model
5464

5565
1. Read this file (baseline standards + operating procedure).

skills/dotnet-domain-primitives/SKILL.md

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,25 @@ domain models. Conversions to/from primitives are permitted only at explicit bou
1010
(persistence, transport, serialization), ensuring type safety and validation throughout
1111
the domain layer.
1212

13-
## Core
13+
## When to Use
14+
15+
- Designing or reviewing domain models (entities, aggregates, commands/events)
16+
- Introducing new entity identifiers (CustomerId, OrderId, TenantId, etc.)
17+
- Working with meaningful primitives that carry validation (EmailAddress, Money, Percentage)
18+
- Reviewing code where primitive types (Guid, string, int) are used for domain concepts
19+
- Implementing API boundaries, persistence layers, or serialization
1420

15-
### When to use
21+
## Core Workflow
1622

17-
- Designing or reviewing domain models (entities, aggregates, commands/events).
18-
- Any non-trivial service where identifiers and "meaningful primitives" recur across layers.
23+
1. **Identify primitive obsession**: Locate places where Guid, string, int, or long represent domain concepts
24+
2. **Define strongly typed IDs**: Create typed ID types using source-generation libraries for entity identifiers
25+
3. **Define value objects**: Create value objects for meaningful primitives with validation (EmailAddress, Money)
26+
4. **Establish boundary conversions**: Map to/from primitives only at explicit boundaries (API, persistence, transport)
27+
5. **Configure serialization**: Add JSON converters, EF Core value converters, and type handlers as needed
28+
6. **Update service signatures**: Change service methods to accept domain primitives, not raw types
29+
7. **Add boundary tests**: Test that boundary conversion works and invalid primitives are rejected
30+
31+
## Core
1932

2033
### Defaults (non-negotiable)
2134

skills/dotnet-efcore-practices/SKILL.md

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,26 @@ Standardise Entity Framework Core usage with dedicated migrations projects exclu
99
coverage, attribute-linked configuration types for entities, and deterministic configuration
1010
discovery. This ensures clean separation between business logic and infrastructure scaffolding.
1111

12-
## Core
12+
## When to Use
13+
14+
- Any solution using EF Core for persistence
15+
- Adding or modifying DbContext, entity types, or configurations
16+
- Creating or updating EF Core migrations
17+
- Setting up code coverage exclusions for infrastructure projects
18+
- Reviewing PRs that change persistence layer structure
1319

14-
### When to use
20+
## Core Workflow
1521

16-
- Any solution using EF Core for persistence.
17-
- Any PR introducing or changing DbContext, entity types, configurations, or migrations.
22+
1. **Verify project structure**: Ensure migrations are in a dedicated `*.Persistence.Migrations` project
23+
2. **Configure coverage exclusion**: Add `<ExcludeFromCodeCoverage>true</ExcludeFromCodeCoverage>` to migrations project
24+
3. **Create configuration types**: Implement dedicated `IEntityTypeConfiguration<T>` for each entity
25+
4. **Link via attributes**: Use attribute-based discovery to connect entities to their configurations
26+
5. **Keep DbContext clean**: DbContext applies configurations, not define them inline
27+
6. **Ensure deterministic ordering**: Configuration scanning uses stable ordering (e.g., by full name)
28+
7. **Verify coverage gate**: Run tests to confirm migrations project excluded from coverage reports
29+
8. **Add repository tests**: Use xUnit with `IAsyncLifetime` for async repository testing
30+
31+
## Core
1832

1933
### Defaults (non-negotiable)
2034

skills/dotnet-healthchecks/SKILL.md

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,25 @@ Standardise health check implementation using the AspNetCore.Diagnostics.HealthC
99
open-source ecosystem. Prefer battle-tested packages over bespoke probes for liveness, readiness,
1010
and dependency health endpoints across databases, caches, message brokers, and external services.
1111

12-
## Core
12+
## When to Use
13+
14+
- Building or modifying ASP.NET Core services that need health endpoints
15+
- Adding health checks for infrastructure dependencies (databases, caches, brokers)
16+
- Implementing Kubernetes liveness and readiness probes
17+
- Reviewing PRs that introduce custom health check implementations
18+
- Configuring orchestration health semantics for containerised services
1319

14-
### When to use
20+
## Core Workflow
1521

16-
- Any ASP.NET Core service exposing liveness, readiness, or dependency health endpoints.
17-
- Any PR introducing health checks for infrastructure dependencies.
22+
1. **Evaluate Xabaril packages**: Check if AspNetCore.Diagnostics.HealthChecks has a package for the dependency
23+
2. **Register health checks**: Add checks via `AddHealthChecks()` with appropriate packages
24+
3. **Separate liveness from readiness**: Tag liveness checks with "live", readiness with "ready"
25+
4. **Map endpoints**: Configure `/health/live` and `/health/ready` with tag-based predicates
26+
5. **Configure orchestration**: Set Kubernetes probes to use appropriate endpoints
27+
6. **Test health checks**: Unit test custom IHealthCheck implementations, integration test endpoints
28+
7. **Verify with curl**: Use `curl -i` to confirm endpoints return expected status codes
29+
30+
## Core
1831

1932
### Defaults (strong preference)
2033

0 commit comments

Comments
 (0)