Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure link on "Using the Web Storage API" page #37592

Closed
sedererdj opened this issue Jan 10, 2025 · 3 comments
Closed

Insecure link on "Using the Web Storage API" page #37592

sedererdj opened this issue Jan 10, 2025 · 3 comments
Labels
Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@sedererdj
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/Web_Storage_API/Using_the_Web_Storage_API

What specific section or headline is this issue about?

misc 'Note' section below the 'basic concepts'

What information was incorrect, unhelpful, or incomplete?

the "pitfalls" hyperlink.

What did you expect to see?

removal of the said link, or cite another source.

Do you have any supporting links, references, or citations?

none

Do you have anything more you want to share?

the said hyperlink, currently pointing to "https://2ality.com/2012/01/objects-as-maps.html" will cause user to jump on a third party website that has sizeable amount of externally loaded scripts. the information provided by the hyperlink is not essential to the content at hand, and it will unnecessarily cause visitors to run a sizable amount of third party JS resources that could be insecure.

MDN metadata

Page report details
@sedererdj sedererdj added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 10, 2025
@github-actions github-actions bot added the Content:WebAPI Web API docs label Jan 10, 2025
@bsmth
Copy link
Member

bsmth commented Jan 10, 2025

Thanks for reporting. I don't see anything wrong with the link, either with the content ("The pitfalls of using objects as maps in JavaScript") or with the site resources it loads. Could you explain why you think it should be removed?

@sedererdj
Copy link
Author

Hello, and thanks for quick reply.

my problem is not with the content provided by the target link per se, but the fact that website at target link loads significant amount of javascript.

currently i cannot provide more details, but i have a suspicion that the said website was used as mean of XSS (or maybe not), least of what i know is that the remote resource run eval() on externally loaded resources which caused my browser to complain.

in any case, the content of the said page is not essential to the article that it is being pointed by, (i know it is style guideline recommendation, but it is misc content), and i think inline note at "Using the Web Storage API" about recommendation of using this API through getter/setter functions is enough without the need for an external link.

@bsmth
Copy link
Member

bsmth commented Jan 10, 2025

I understand. I don't think we'll be removing it on those grounds, as it appears to be quite light on resources, you may want to check disabling / allowlisting JavaScript via some methods here if you're looking to avoid using too much data / bandwidth: https://support.mozilla.org/en-US/kb/javascript-settings-for-interactive-web-pages

I'll close for now, thank you!

@bsmth bsmth closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
Development

No branches or pull requests

2 participants