Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure Cookies: Recommendation of Expires vs Max-Age? #37640

Closed
cycomachead opened this issue Jan 14, 2025 · 1 comment · Fixed by #37674
Closed

Secure Cookies: Recommendation of Expires vs Max-Age? #37640

cycomachead opened this issue Jan 14, 2025 · 1 comment · Fixed by #37674
Labels
Content:Security Security docs good first issue A good issue for newcomers to get started with.

Comments

@cycomachead
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/Security/Practical_implementation_guides/Cookies

What specific section or headline is this issue about?

Solution

What information was incorrect, unhelpful, or incomplete?

The text includes the line:

Expires is preferred unless you need to support IE < 8, in which case use Max-Age.

Given the benefits of Max-Age, should this sentence not be reversed?

What did you expect to see?

I thought Max-Age was the preferred form of setting a cookie's expiration date.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@cycomachead cycomachead added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 14, 2025
@github-actions github-actions bot added the Content:Security Security docs label Jan 14, 2025
@Josh-Cena
Copy link
Member

Josh-Cena commented Jan 16, 2025

We don't even need this sentence at all, since we don't care about ancient browsers anymore.

@Josh-Cena Josh-Cena added good first issue A good issue for newcomers to get started with. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Security Security docs good first issue A good issue for newcomers to get started with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants